-
Notifications
You must be signed in to change notification settings - Fork 175
Update strum to Rust edition 2018 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening the PR :) It looks like the build failures are legit, and there's probably some missing usings in the test cases. I'll be good to merge this once we fix the build. |
Huh, so really the way to solve this would be changing I guess the doctests could also have use strum_macros::Foo;
use strum::Foo as _; but really in the real world everybody would write use strum::Foo; instead and activate the |
@Peternator7 friendly ping |
I was poking around with this locally, and it looks to me like it works if I call If that's the case, we might be able to just update the appveyor script to call |
Yes, by calling |
So I think I'm okay with that. The only people really running the tests should be contributors to this repo, and I would expect the most natural thing for someone to do is build the workspace and that works as expected. I pushed some changes last night that fixed the build and started actively building 1.31 for appveyor. The gates on this PR pass now so let me review the content, but we should be good wrt the build. |
Fixes #109.
I've updated the docs too (removing the mentions of
extern crate
), is that okay?