DateTime::Format::* does not have format_timestamp_without_timezone m… #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So there is no test for this, neither for Oracle nor for PostgreSQL so this was unnoticed for so many years? Please add at least one test case so it can't happen again, thanks! |
|
Ping |
|
As written earlier can you please also add a test case? Thanks! |
|
Yes, I'll do this or next week. I have a bit of time. Right now I am working on PR for SQL::Translator. |
KES777
changed the title
|
Done! |
…thod The timezone should be spelled as 'time_zone'. https://metacpan.org/pod/DateTime::Format::Pg#PARSING-METHODS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: RT133622
https://metacpan.org/pod/DateTime::Format::Oracle
https://metacpan.org/pod/DateTime::Format::Pg
Has method 'format_timestamp_with_time_zone' so we should rename