Assert that Copy's source and destination do not overlap #23594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These macros are identical to the ...D forms except for their return type, which is void. So just define Move/Copy/Zero in terms of MoveD/CopyD/ZeroD.
It is a bit hard to tell (and even harder to change) what exactly these macros are doing if everything is crammed into one line.
memcpy() has undefined behavior if the source/destination ranges overlap, so assert that they don't.
khwilliamson
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memcpyhas undefined behavior if the source/destination ranges overlap, so assert that they don't.