Don't run tests with cpanm installs for the image #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpanm runs tests for everything it installs, which might be a good thing or a bad thing. It depends mostly on flavor. cpm will install modules without running tests by default for example. This commits still uses cpanm, but with the --notest flag so we can improve on our build times. Closes: Perl#195 Signed-off-by: Wesley Schwengle <[email protected]>
tianon
reviewed
Aug 28, 2025
generate.pl
Outdated
| @@ -319,6 +319,8 @@ =head1 DESCRIPTION | |||
| {{docker_copy_perl_patch}} | |||
| WORKDIR /usr/src/perl | |||
|
|
|||
| ARG TARGETARCH | |||
There was a problem hiding this comment.
Unfortunately we don't officially support or recommend relying on TARGETARCH -- I would suggest using dpkg --print-architecture and/or apk --print-arch instead (I don't think we've got any Alpine here, but just in case / for completeness).
There was a problem hiding this comment.
Hmm, ok. I'll change it
waterkip
force-pushed
the
195-notest_for_cpanm
branch
2 times, most recently
from
8a3a8ad to
b85018d
Compare
I tried to rely on TARGETARCH, but unfortunatly Docker doesn't officially supports or recommends using it. If we ever need alpine support: apk --print-arch The testsuite takes to long on the single riscv64 for all trixie builds. Context: > Unfortunately, our singular riscv64 build server in Docker Official > Images is unable to complete any of the perl image builds. We have a > 3-hour time limit on all builds (to ensure things don't get stuck and > prevent resource monopolization) and none of them are able to complete > in that time. Is there anything that could be skipped or changed on > riscv64 builds to help them complete faster? https://doi-janky.infosiftr.net/job/meta/job/riscv64/job/build/13644/pipeline-overview/ Closes: Perl#195 Signed-off-by: Wesley Schwengle <[email protected]>
Signed-off-by: Wesley Schwengle <[email protected]>
waterkip
force-pushed
the
195-notest_for_cpanm
branch
from
b85018d to
25f8602
Compare
zakame
requested changes
Sep 18, 2025
| @@ -330,15 +330,15 @@ =head1 DESCRIPTION | |||
| && archFlag="$([ "$archBits" = '64' ] && echo '-Duse64bitall' || echo '-Duse64bitint')" \ | |||
| && ./Configure -Darchname="$gnuArch" "$archFlag" {{args}} {{extra_flags}} -des \ | |||
| && make -j$(nproc) \ | |||
| && {{test}} \ | |||
| && { [ "$(dpkg --print-architecture)" = 'riscv64' ] || {{test}}; } \ | |||
There was a problem hiding this comment.
I guess we can now disregard this per #195 (comment)
| && make install \ | ||
| && cd /usr/src \ | ||
| && curl -fLO {{cpanm_dist_url}} \ | ||
| && echo '{{cpanm_dist_sha256}} *{{cpanm_dist_name}}.tar.gz' | sha256sum --strict --check - \ | ||
| && tar -xzf {{cpanm_dist_name}}.tar.gz && cd {{cpanm_dist_name}} \ | ||
| && {{cpanm_dist_patch_https}} \ | ||
| && {{cpanm_dist_patch_nolwp}} \ | ||
| && perl bin/cpanm . && cd /root \ | ||
| && perl bin/cpanm --notest . && cd /root \ |
There was a problem hiding this comment.
Perhaps we can take this as an ARG with a default --notest so we can pass `` later in GHA builds here and below at lines 344 & 347? That way official-image builds can proceed faster while we can affirm tests on our own CI here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cpanm runs tests for everything it installs, which might be a good thing or a bad thing. It depends mostly on flavor. cpm will install modules without running tests by default for example. This commits still uses cpanm, but with the --notest flag so we can improve on our build times.
Closes: #195