ENH: harden transformToWorld of exported models#15
ENH: harden transformToWorld of exported models#15mauigna06 wants to merge 2 commits intoPerkLab:masterfrom
Conversation
lassoan
left a comment
lassoan
left a comment
There was a problem hiding this comment.
Thank you, this will be good, just please address the inline comment.
lassoan
left a comment
lassoan
left a comment
There was a problem hiding this comment.
Thanks, this will be good, I just added a few nitpicky comments.
You can make changes in Slicer using the web interface. A pull request is automatically created and tests are executed on it.
| transformer.SetTransform(ras2lpsTransform) | ||
| transformer.SetInputConnection(outputModelNode.GetPolyDataConnection()) | ||
| transformOutputModelToWorldRAS = vtk.vtkGeneralTransform() | ||
| transformOutputModelToWorldRAS.PostMultiply() |
There was a problem hiding this comment.
This needs to come after the slicer.vtkMRMLTransformNode.GetTransformBetweenNodes(inputModelNode.GetParentTransformNode() call.
| transformOutputModelToWorldRAS.PostMultiply() | ||
| slicer.vtkMRMLTransformNode.GetTransformBetweenNodes(inputModelNode.GetParentTransformNode(), None, transformOutputModelToWorldRAS) | ||
|
|
||
| transformOutputModelToWorldLPS = transformOutputModelToWorldRAS |
There was a problem hiding this comment.
This doesn't really explain things. You could create a new vtkGeneralTransform instead just assigning a new name but that would be a bit overcomplicated,l. Probably using just the transformOutputModelToWorldLPS name and a good comment would be sufficient.
2 participants
Related #14