psmdb-image-preparation #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvpasinatto
reviewed
Jul 4, 2024
| @@ -0,0 +1,59 @@ | |||
| repo='percona' | |||
There was a problem hiding this comment.
Can we change the extension to .sh and put the shebang #!/usr/bin/env bash?
jvpasinatto
requested changes
Jul 4, 2024
Comment on lines
+12
to
+15
| export PSMDB_IMAGES_PROJECT_ID="5e627846b6bf136294e8bb8b" | ||
| export PSMDB_OPERATOR_PROJECT_ID="5e62470102235d3f505f60e3" | ||
| export PSMDB_IMAGES_PROJECT_USER="redhat-isv-containers+5e627846b6bf136294e8bb8b-robot" | ||
| export PSMDB_OPERATOR_PROJECT_USER="redhat-isv-containers+5e62470102235d3f505f60e3-robot" |
There was a problem hiding this comment.
Are these private?
Also ,we can simplify to PSMDB_IMAGES_PROJECT_USER="redhat-isv-containers+$PSMDB_IMAGES_PROJECT_ID-robot" and the same for the operator
| operator_image_id=`docker images | grep "${release} " | awk '{print $3}'` | ||
| echo $operator_image_id | ||
| docker tag $operator_image_id quay.io/redhat-isv-containers/${PSMDB_OPERATOR_PROJECT_ID}:${release} && docker push quay.io/redhat-isv-containers/${PSMDB_OPERATOR_PROJECT_ID}:${release} | ||
| preflight check container --platform=linux/amd64 quay.io/redhat-isv-containers/${PSMDB_OPERATOR_PROJECT_ID}:${release} --docker-config=/Users/marukovich/.docker/config.json --submit --pyxis-api-token=$PYXIS_API_TOKEN --certification-project-id=$PSMDB_OPERATOR_PROJECT_ID |
There was a problem hiding this comment.
I think we should create an env var for the docker config file. Please check the same in the cmds below
jvpasinatto
reviewed
Jul 5, 2024
| @@ -0,0 +1,59 @@ | |||
| repo='percona' | |||
| psmdb-operator="percona-server-mongodb-operator" | |||
There was a problem hiding this comment.
change to psmdb_operator here and in line 27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.