Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Office M2 mac runners to ubuntu-22.04-arm runners #1606

Draft
wants to merge 80 commits into
base: main
Choose a base branch
from

Conversation

runora95
Copy link
Contributor

@runora95 runora95 commented Apr 3, 2025

Before submitting

Please complete the following checklist when submitting a PR:

  • All new functions and code must be clearly commented and documented.

  • Ensure that code is properly formatted by running make format.
    The latest version of black and clang-format-14 are used in CI/CD to check formatting.

  • All new features must include a unit test.
    Integration and frontend tests should be added to frontend/test,
    Quantum dialect and MLIR tests should be added to mlir/test, and
    Runtime tests should be added to runtime/tests.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@runora95 runora95 marked this pull request as draft April 3, 2025 19:23
@runora95 runora95 marked this pull request as ready for review April 3, 2025 19:23
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@runora95 runora95 added the author:build-wheels Run the wheel building workflows on this Pull Request label Apr 3, 2025
@runora95 runora95 marked this pull request as draft April 3, 2025 21:03
@dime10
Copy link
Contributor

dime10 commented Apr 3, 2025

Awesome thanks for tackling this! Ideally I'd like to see this PR remove everything under workflows/scripts, since that only existed because we were using docker, and instead follow the same structure we have in the wheel-build workflows for the other platforms.

@runora95 runora95 changed the title Changing Offive M2 mac runners to ubuntu-22.04-arm runners Changing Office M2 mac runners to ubuntu-22.04-arm runners Apr 4, 2025
@runora95
Copy link
Contributor Author

runora95 commented Apr 4, 2025

Awesome thanks for tackling this! Ideally I'd like to see this PR remove everything under workflows/scripts, since that only existed because we were using docker, and instead follow the same structure we have in the wheel-build workflows for the other platforms.

That makes a lot of sense, thanks @dime10!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author:build-wheels Run the wheel building workflows on this Pull Request do-not-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants