Update mlir version to have closure-aware backward slice #1585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Proposal: we update the mlir commit we track to see llvm/llvm-project#114452
When using backward slice to track def-use chains, sometimes there are closure variables not explicitly visible as an operand, e.g.
when running backward slice on
%11
to track all necessary previous values that dominate%11
, the current mlir commit we track cannot detect%7
, because%7
is not an explicit operand of thescf.if
op, but implicitly captured by region closure. The proposed commit to track adds a new option,omitUsesFromAbove
, to the mlir backward slice analysis, and can be turned off to include clousure variables.Description of the Change:
Update the mlir commit we track
Benefits:
New mlir features available
Possible Drawbacks:
Updating versions might break things