load all dialects preemptively

[erick-xanadu]

Context: The transform dialect appears not to load dependent dialects of transformations.

Description of the Change: Load all dialects preemptively.

Benefits: Third party developers (and even first party developers) can generate operations in unloaded dialects from within the apply-sequence-pass.

Possible Drawbacks: This is a workaround. We should investigate some time to see where exactly the error comes from.

[sc-88453]

[paul0403]

Wait, was this not solved? 😅 I remember this either went away on its own or there was a hack? @sengthai

[erick-xanadu]

@paul0403 I am not sure if it was solved / how it was solved. But I know that an external collaborator encountered the same issue when loading an external dialect. So, @sengthai , if you remember how this was mitigated, please let us know. :)

[sengthai]

At that time, that error disappeared, then it came back and forth. However, It was entirely solved by adding dependentDialects in ApplyTransformSequencePass. 🤔

catalyst/mlir/include/Catalyst/Transforms/Passes.td

Lines 184 to 192 in 8b385c1

	def ApplyTransformSequencePass : Pass<"apply-transform-sequence"> {
	let summary = "Apply the passes scheduled with the transform dialect.";
	let dependentDialects = [
	"qec::QECDialect"
	];
	let constructor = "catalyst::createApplyTransformSequencePass()";
	}

[erick-xanadu]

At that time, that error disappeared, then it came back and forth. However, It was entirely solved by adding dependentDialects in ApplyTransformSequencePass. 🤔

Thanks! Yes, this is not a viable solution in the long term. I think we may need to update the source upstream.

[sengthai]

Thanks for this PR, Erick. I tested ppm's passes, and they work great! I also went ahead and removed the empty dependentDialects in the latest commit.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (a2b886b) to head (4584b7b).
Report is 11 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
+ Coverage   96.47%   96.60%   +0.13%     
==========================================
  Files          80       80              
  Lines        8556     8606      +50     
  Branches      819      832      +13     
==========================================
+ Hits         8254     8314      +60     
+ Misses        246      238       -8     
+ Partials       56       54       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[erick-xanadu]

This one is hard to test for plugins because the standalone plugin in MLIR does not have a pass that depends on the standalone dialect. So I would need to create a pass to test it. I propose we merge this. We see that it already solves the issue with the QEC dialects.

[erick-xanadu]

Patrick Hopf successfully tested this out. I'll be merging after standup.