Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require db be empty to create test db #41

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Ulthran
Copy link
Contributor

@Ulthran Ulthran commented Nov 21, 2024

No description provided.

@Ulthran Ulthran linked an issue Nov 21, 2024 that may be closed by this pull request
@Ulthran Ulthran merged commit 9490522 into master Nov 21, 2024
7 of 8 checks passed
@Ulthran Ulthran deleted the 40-more-safeguards-around-test-db-creation branch November 21, 2024 17:54
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@b2ba39c). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
app/sample_registry/src/sample_registry/db.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   85.82%           
=========================================
  Files             ?       13           
  Lines             ?      931           
  Branches          ?        0           
=========================================
  Hits              ?      799           
  Misses            ?      132           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More safeguards around test db creation
1 participant