[docker] Add ARM support where available from upstream #3655
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robkooper
approved these changes
Nov 17, 2025
Member
robkooper
left a comment
robkooper
left a comment
There was a problem hiding this comment.
looks good, left a comment, feel free to take it.
Not tested yet since we need images build :(
| # upstream rocker/tidyverse image is only on ARM for R 4.5.* (so far) | ||
| shell: bash | ||
| run: | | ||
| if [[ "${{ join(steps.*.outputs.R_VERSION, '') }}" == "4.5" ]]; then |
Member
There was a problem hiding this comment.
more complex, but do we want to use explicit if 4.1 the x86, etc, then else arm. That way develop also compiles with arm. Once we disable 4.2 and add 4.6 it does not need any updates, except removal of 4.2
Member
Author
There was a problem hiding this comment.
I implemented it that way at first, then realized rocker/tidyverse:devel doesn't' provide an arm version yet. I'll merge this and plan to add the complexity back whenever the list of x86-only versions gets shorter than the list of versions with arm.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
PecanProject:develop
with commit Nov 18, 2025
bd03fdc
19 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows declaration of Docker platform support to vary by R version as well as by image, and uses it to add ARM support when R version is 4.5.
Motivation and Context
The Rocker project is now providing an arm64 build of the tidyverse image, thus far for R 4.5 only. I'd love to use it on my machine!
One relevant question is how much complexity is needed here and how long we'll need to support a mix of platforms instead of assuming dual amd64/arm64 everywhere. I think the answer is "a while" -- Rocker's general approach is to not backport changes like this to older images, so I expect the R 4.2 through 4.4 images to stay AMD-only, and it's not clear if/when they plan to add ARM support to the R-devel image.
Review Time Estimate
Types of changes
Checklist: