fix(data.land): use year-specific crop data in generate_events #3649
Conversation
| dplyr::distinct() |> | ||
| tidyr::crossing(year = 2016:2024) |> | ||
| dplyr::select(site_id, year, pft, crop) |> | ||
| dplyr::filter(year >= 2016 & year <= 2024) |> |
There was a problem hiding this comment.
@AritraDey-Dev this looks right once we have data from multiple years in hand, but do note that the ca_field_attributes I know about currently only contains rows for 2016. Have you tested this patch with a multi-year field listing?
There was a problem hiding this comment.
@infotroph I didn't test it separately with a multi-year field listing, given your comment on the issue that ca_field_attributes currently only contains rows for 2016, I've implemented a fix based on the issue you raised regarding the crop being repeated for every year until 2024.
There was a problem hiding this comment.
Tagging @dlebauer as the main user of this script so far -- your call whether we should to make this change now (and therefore have output be 2016-only until the field attributes file contains other years), or keep crossing(2016:2024) until we have an updated attribute file in hand?
2 participants
Description
Fix generate_events to use year-specific crop data instead of repeating 2016 crop data across all years
Motivation and Context
Fixes #3636
Review Time Estimate
Types of changes
Checklist: