Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing curl Package to manual-test.yaml as Dependency #14

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

Sweetdevil144
Copy link
Contributor

Summary

This pull request addresses an issue in our GitHub Actions workflow where the R environment was missing the curl package, leading to a failure in the execution of manual-test.yaml.

Issue Description

During the execution of our GitHub Actions workflow, particularly in the "Generate data" step within run-test-list.yaml, we encountered an error indicating that the curl package was not installed. The error message was as follows:

Error: Error in loadNamespace(x) : there is no package called ‘curl’

This issue was causing the workflow to halt prematurely, preventing the completion of our automated test suite.

Proposed Changes

To resolve this issue, I have added an additional command in the "Install dependencies" step of our manual-test.yaml workflow. This command explicitly installs the curl package in our R environment, ensuring that all necessary dependencies are available for our scripts.

The updated section of the workflow file is as follows:

- name: Install dependencies
  run: |
    remotes::install_deps(dependencies = TRUE)
    install.packages("XML")
    install.packages("devtools")
    devtools::install_github("PecanProject/rpecanapi")
    install.packages("dplyr")
    install.packages("tidyr")
    install.packages("curl") # Added to ensure the availability of the curl package
  shell: Rscript {0}

Impact

With the addition of the curl package, our automated testing workflow should now run without encountering the previous error. This will enable us to reliably generate and test data as part of our continuous integration process, ensuring the stability and reliability of our codebase.

Testing

After making this change, the workflow should be re-run to verify that the "Generate data" step completes successfully without encountering the previous error. Taking into account the amount of errors we have been seeing in our *.csv files, I'm sure we'll get to encounter another errors after this.

@infotroph Requesting a review on this pull request.

@Sweetdevil144 Sweetdevil144 changed the title Add Missing curl Package to manual-test.yaml as *Dependency* Add Missing curl Package to manual-test.yaml as Dependency Mar 10, 2024
@mdietze mdietze merged commit 9cc67ac into PecanProject:main Mar 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants