Interface & Visualization #50

im-prakher · 2020-06-25T19:02:03Z

No description provided.

KristinaRiemer · 2020-06-26T15:25:03Z

So I was trying to follow along with the interface README. When I ran yarn start, it returned this error: Command failed with exit code 127. After some Googling, apparently just yarn needs to be run first, and then yarn start worked. So that should be added to the README.

This is how the first page looks for me:

Added install dependencies section

Chris-Schnaufer

Can you comment where you're using generated files vs. ones that you created and/or modified. I think this would help reviewers.
Adding comments to files as to the intent of the file would help people understand what they're about. Especially for example, upload1.js and upload2.js.
Python documentation strings are missing in python code

app/Meta.py

Chris-Schnaufer · 2020-06-30T17:14:37Z

app/Meta.py

            for pt in list(row['geometry'].exterior.coords):
                pt=pt+(115,)
                flat_list.append(pt)
            poly = Polygon(flat_list)
            data.loc[index, 'geometry'] = poly

        if(all(x in accepted_columns for x in columns)):
-            data['notes']=data_g['notes']
-            #data['geometry']=data_g['geometry']
            data['time_zone'].fillna("America/Phoenix", inplace = True)
            data['soilnotes'].fillna("some text", inplace = True)      


I feel the term "some text" should be replaced with "No notes". I feel that this is clearer

app/Meta.py

Chris-Schnaufer · 2020-06-30T17:23:51Z

app/Meta.py

@@ -191,8 +181,7 @@ def insert_sites(fileName,shp_file,dbf_file,prj_file,shx_file):
        os.remove(shp_file_target)
        os.remove(dbf_file_target)
        os.remove(prj_file_target)
-        os.remove(shx_file_target)
-        os.remove(file_name)        


os.remove(file_name) should remain here so that it's cleaned up when a problem occurs. Checking if the file exists before trying to remove it would prevent a missing file exception from being raised

if os.path.exists(file_name): os.remove(file_name)

os.remove(file_name) should be there.Otherwise file contents will be appended with existing ones when that endpoint is called next time.

client/client.py

Chris-Schnaufer · 2020-06-30T18:21:09Z

visualization/pg_joins.js

+}
+
+
+const getTable1=async (cultivars, sites_cultivars, sites) => {


Use a more descriptive name here instead of "getTable1". Perhaps insertCultivarSites?

Thanks! for pointing out, will change it in a future commit.

Chris-Schnaufer · 2020-06-30T18:21:31Z

visualization/pg_joins.js

+  }
+}
+
+const getTable2=async (experiments, experiments_sites, sites) => {


Use a more descriptive name than "getTable2" here

Thanks! for pointing out, will change it in a future commit.

Chris-Schnaufer · 2020-06-30T18:22:46Z

visualization/pg_joins.js

+
+    sites.pop();
+    sites.pop();
+    sites.push("some text")


Use "No notes" here as well

Chris-Schnaufer · 2020-06-30T18:23:53Z

visualization/pg_joins.js

+    await client.query(query2);
+
+    sites.pop();
+    sites.push("some text")


Use "No notes" here and everywhere else soilnotes defaults to ~~"some text"~~

visualization/pg_joins.js

Co-authored-by: Chris Schnaufer <[email protected]>

Chris-Schnaufer · 2020-07-02T20:34:53Z

app/Meta.py

        for index, row in data_g.iterrows():
+            flat_list = []
            for pt in list(row['geometry'].exterior.coords):
                pt=pt+(115,)


This line of code adds another dimension to the loaded point. This causes problems when the points already have a Z value when loaded from the shapefile (point has 3 dimensions); after this line the point will have 4 dimensions and cause a failure

Another comment on this is that every point that doesn't have a Z value will be assigned an elevation of 115 meters. IMO it would be better to default to zero or some other value indicating that it's probably not correct (unless you're at sea level)

app/Meta.py

dlebauer

@im-prakher try " " instead of no notes?
@Chris-Schnaufer could you provide more explicit instructions or go ahead and implement your suggestions below for .shp file and time zone handling? It isn't clear how challenging this would be but I think especially the shapefile handling could become a rabbit hole for someone not as familiar w/ GIS as you.

client/client.py

interface/public/tw.svg

dlebauer · 2020-07-03T15:48:12Z

visualization/pg_joins.js

+    await client.query(query2);
+
+    sites.pop();
+    sites.push("some text")


Suggested change

sites.push("some text")

sites.push("")

dlebauer · 2020-07-03T15:48:32Z

visualization/pg_joins.js

+
+    sites.pop();
+    sites.pop();
+    sites.push("some text")


Suggested change

sites.push("some text")

sites.push("")

dlebauer · 2020-07-03T15:48:51Z

visualization/pg_joins.js

+
+    sites.pop();
+    sites.pop();
+    sites.push("some text")


Suggested change

sites.push("some text")

sites.push("")

dlebauer · 2020-07-03T15:49:06Z

visualization/pg_joins.js

+
+    sites.pop();
+    sites.pop();
+    sites.push("some text")


Suggested change

sites.push("some text")

sites.push("")

dlebauer · 2020-07-03T15:49:26Z

visualization/pg_joins.js

+                  site.pop()
+                  site.pop()
+                  site.pop()
+                  site.push("some text")


Suggested change

site.push("some text")

site.push("")

dlebauer · 2020-07-03T15:50:02Z

visualization/pg_joins.js

+                  site.pop()
+                  site.pop()
+                  site.pop()
+                  site.push("some text")


Suggested change

site.push("some text")

site.push("")

interface/src/components/navbar.js

KristinaRiemer · 2020-07-17T15:36:21Z

@dlebauer or @Chris-Schnaufer would you be able to confirm your review so that this PR can be merged?

app/Meta.py

…into interface

Co-authored-by: Chris Schnaufer <[email protected]>

Co-authored-by: David LeBauer <[email protected]>

im-prakher · 2020-07-20T15:42:03Z

This PR is now complete in itself, please have a final review and then merge it.
@Chris-Schnaufer @KristinaRiemer @dlebauer @saurabh1969

im-prakher · 2020-07-20T17:56:09Z

Due to a lot of lines of code in this PR, it might be challenging to review the work done in recent commits so to make this easier, I have opened issues(regarding the recent commits) that are implemented in this PR.

dlebauer · 2020-07-10T15:23:17Z

interface/README.md

+
+ Before running the project, run:
+
+### `yarn`


Use code blocks for indicating code, e.g.

yarn

link to code for installing yarn https://classic.yarnpkg.com/en/docs/install

describe OS requirements

tell user to cd interface

app/Meta.py

client/client.py

interface/src/App.test.js

visualization/pg_joins.js

app/Meta.py

im-prakher and others added 3 commits June 26, 2020 00:16

Interface & Visualization

c334afe

Delete client.json

d167ab1

Delete package-lock.json

50088c7

dlebauer mentioned this pull request Jun 26, 2020

Enable CORS (Cross-Origin Resource Sharing) for the api #45

Closed

KristinaRiemer changed the title ~~Interface & Visualization~~ WIP Interface & Visualization Jun 26, 2020

Update README.md

efb3b23

Added install dependencies section

Chris-Schnaufer reviewed Jun 30, 2020

View reviewed changes

Update interface/src/components/upload1.js

606f11d

Co-authored-by: Chris Schnaufer <[email protected]>

Chris-Schnaufer reviewed Jul 2, 2020

View reviewed changes

dlebauer reviewed Jul 3, 2020

View reviewed changes

app/Meta.py Outdated Show resolved Hide resolved

dlebauer reviewed Jul 3, 2020

View reviewed changes

app/Meta.py Show resolved Hide resolved

dlebauer requested changes Jul 3, 2020

View reviewed changes

dlebauer reviewed Jul 10, 2020

View reviewed changes

interface/src/components/navbar.js Outdated Show resolved Hide resolved

alt text

589462d

dlebauer requested a review from saurabh1969 July 10, 2020 15:18

KristinaRiemer changed the title ~~WIP Interface & Visualization~~ Interface & Visualization Jul 17, 2020

Chris-Schnaufer reviewed Jul 17, 2020

View reviewed changes

app/Meta.py Outdated Show resolved Hide resolved

im-prakher and others added 8 commits July 18, 2020 20:59

Final Changes

8711355

Merge branch 'interface' of https://github.com/im-prakher/BETYdb-YABA …

6f83593

…into interface

Update upload1.js

e86ff9e

Fixed redirects and error page functionality

3fbf04b

Update app/Meta.py

8804182

Co-authored-by: Chris Schnaufer <[email protected]>

Update app/Meta.py

70baee9

Co-authored-by: David LeBauer <[email protected]>

Replace "some text" with "" in Meta.py

eab419f

Co-authored-by: David LeBauer <[email protected]>

Merge branch 'master' into interface

ee818a8

Update Meta.py

c622e2a

im-prakher mentioned this pull request Jul 24, 2020

Containerize the Interface and Visualization part of the YABA app #53

Closed

This was referenced Jul 24, 2020

Remove responsive navbar ... #61

Closed

if time zone isn't required, leave it out (or insert empty string ''). #62

Open

dlebauer approved these changes Jul 24, 2020

View reviewed changes

dlebauer merged commit 3d86329 into PecanProject:master Jul 24, 2020

im-prakher deleted the interface branch February 1, 2021 10:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Interface & Visualization #50

Interface & Visualization #50

im-prakher commented Jun 25, 2020

KristinaRiemer commented Jun 26, 2020

Chris-Schnaufer left a comment

Chris-Schnaufer Jun 30, 2020

Chris-Schnaufer Jun 30, 2020

saurabh1969 Jul 16, 2020 •

edited

Loading

Chris-Schnaufer Jun 30, 2020

im-prakher Jul 1, 2020

Chris-Schnaufer Jun 30, 2020

im-prakher Jul 1, 2020

Chris-Schnaufer Jun 30, 2020

Chris-Schnaufer Jun 30, 2020

Chris-Schnaufer Jul 2, 2020

Chris-Schnaufer Jul 17, 2020

dlebauer left a comment

dlebauer Jul 3, 2020

dlebauer Jul 3, 2020

dlebauer Jul 3, 2020

dlebauer Jul 3, 2020

dlebauer Jul 3, 2020

dlebauer Jul 3, 2020

KristinaRiemer commented Jul 17, 2020

im-prakher commented Jul 20, 2020

im-prakher commented Jul 20, 2020

dlebauer Jul 10, 2020

dlebauer Jul 10, 2020

		}


		const getTable1=async (cultivars, sites_cultivars, sites) => {

Interface & Visualization #50

Interface & Visualization #50

Conversation

im-prakher commented Jun 25, 2020

KristinaRiemer commented Jun 26, 2020

Chris-Schnaufer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saurabh1969 Jul 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dlebauer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KristinaRiemer commented Jul 17, 2020

im-prakher commented Jul 20, 2020

im-prakher commented Jul 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

saurabh1969 Jul 16, 2020 •

edited

Loading