fix: replace v-show to v-if in order to use it with all types of vue components #289
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
v-show
directive for hiding slots can cause some issues, for example, if you have a modal content for loader provided by vue-portal it can't be hidden just withdisplay: none
( v-show ). In such cases it's important to usev-if
directive.This code won't work if I'll use
vue-portal
because portals can't be hidden viav-show
and as the result - we will see a modal all the time on a screen.This issue can be fixed replacing all
v-show
's which are using to hide slot content tov-if
directives.