fix path finding in express #148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
could you please add new test and also check why ci is failing? |
Collaborator
|
Still missing test :) |
Author
Need to study testing framework a little bit... |
Collaborator
|
@kibertoad anything else is missing? |
Collaborator
|
@Kenblair1226 Would that work correctly when addressing parametrized routes? Wouldn't this result in passing ids etc as a part of route as well? |
Author
|
Ya, the params will be treated as path and mostly be ignored since not matching any schema. Any suggestion? |
Collaborator
|
@Kenblair1226 Something like this, I think: #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #81, borrow from @evelyne24's fix to use req.path if req.route does not exist.