Skip to content

Conversation

@lqwert
Copy link
Contributor

@lqwert lqwert commented Oct 19, 2020

Final implementation of my BA

Related to PatternAtlas/pattern-atlas-api#19
and PatternAtlas/pattern-atlas-docker#9

@lqwert lqwert requested review from manuwei and marzn October 19, 2020 15:38
Copy link
Contributor

@manuwei manuwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TYueksel I tested the authentification and flow and after creating a user, could get redirected to the UI again (error="invalid_grant", error_description="Invalid redirect: http://localhost:1978 does not match one of the registered values.") - is there any other config I still need to change manually to get it running?

Besides from that, the build failed due to lint errors - please fix it (npm run lint)

@mhinkie mhinkie requested a review from buehlefs August 1, 2022 15:30
Copy link
Contributor

@buehlefs buehlefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor issues left.

Copy link
Contributor

@buehlefs buehlefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhinkie mhinkie merged commit 06ab45e into master Aug 2, 2022
@lharzenetter lharzenetter deleted the ba-meyer-master branch August 2, 2022 14:04
@mhinkie mhinkie mentioned this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants