Fix first explicit mod missing when it has no parsing #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The item parsing logic in WIKI mode seems to rely on finding a mod that produces a modList to set the foundExplicit variable to true which then allows mods that do not produce a modList to be added to lineList. This causes issues with items such as Dialla's Malefaction where the first explicit line does not have any parsing which causes it to not be added to linesList. Interestingly enough other mods wihch are parsed piece-wise work fine here as they produce and empty modList with the extras paramter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8408 and likely other cases of such problems
Description of the problem being solved:
The item parsing logic in WIKI mode seems to rely on finding a mod that produces a modList to set the foundExplicit variable to true which then allows mods that do not produce a modList to be added to lineList. This causes issues with items such as Dialla's Malefaction where the first explicit line does not have any parsing which causes it to not be added to linesList. Interestingly enough other mods which are parsed piece-wise work fine here as they produce and empty modList with the extras parameter.
This pr attempts to fix the problem while being the least invasive and lowering the chance of some parsing edge case failing. There could totally be a much nicer solution to this problem.