Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dominating Blow Hit counting multiple times when used in FullDPS #8574

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Mar 14, 2025

Closes #8564

Description of the problem being solved:

The Dominating Blow skill has a similar issue to the Absolution skill where increasing count increases not only the "minion count" but also applies a multiplier on the base skill damage.

This commit essentially copies
#4653 and applies it to Dominating Blow.

Link to a build that showcases this PR:

eNrNXFtz4joSfp78ChfvA9jcU8k5RW6TbIUJC5mZ3acpYQvQGWExtpyEs7X_fVuSb4BlbOyHZaoSY_fX3eqWWt0tZ67-_NhQ4w17PmHudcNsthsGdm3mEHd13fj2-vB52Pjzj4urKeLrl-VNQKh48sfFpyt5bVD8hingGgZH3grz7xGnzk_gtEUuX2PmTtBfzPvCnOvGV-bihrFArkN49M2myPe_og2-bsxtADcM5NvYdW6T-yHhGnnI5th7FlLHAWcT5sBT7gXwdIOIO2f2L8y_eCzYSqXeCH5XNE-T6cvsNaUScdMqwYg-XU0p2mFvzhE3fPhx3RiDYdAKPxIOrBANgE-nM2h225bVa7RyMTeB5_M7tIHL4tj5FmMnJjebnfRHB5p6-H65xDYnb_jWI_x2jVw7EdrX4crSTgLKyZYS7KU01A7l8Yi52W7riF8ZR_RuOo9pu91Rc9gf9dVnkI9jiXe0En4Qvr6hYN0zpAjs08olHJ8JnjLiM7fC-NJQ7RBvA0phbRainWEfe2-Ik3219LzZZkHcs6w39jB6WaoZOkMOCfwJ5h72k1XRNHXYCXLRLfMT_1r9PNIp9iBu8D1E-wRgjm0GoSYN6XSb_eQzKCAxm49W9DNZ4uKUpUYVAspqc9447udF6UozPk-hGUTbYpRzFtCClDyJd1bOgvq9R6invMMfBfg9ubyY1DRhf6gX-sa43FpPDVeGnPvHabIahk3LGpnWoD0Y6Heu6XrnExvRCfogm2AD0f8V_cKJvH7O9FutuQuBSwftaFfgA_FwedQto84ZqDVivhY2zFtcBYwAG799KWifXLvYiv3mejKGp_KFfi5gButIpCYLigsiEhHhaiyylStRK-yG8nbFhvOMsb3-AhncDHFcLHjHVL18swraQmYVhBlm7RUElDCSAGqM1BzlgUqa6d7F3mo3XxNMnXLUkWK3aFsgRAozp9GFzL0vrtSMSUNLmuQH8pxiG0lZnd6Qn46wZj_fXIq82MTEkLkCwMEHKXVbXxOwv0RFQMvBxt6GBV5BhyviQgOIdgdVD82wE9jFdqO4sLmhUNkVHUaMAj0pLQUdc47sX3fMWRU2mhRSCrGv3zzYbiGGiNlQlIHY-CCFJ6n85XO_APULTOVCK1rskcUFJNSFBcS7fnEpB5DiYxE7d4nBJOSFRcQOnUCw2MAmIAv5CUvV8lrnQNWWrqrMYb_bNAeDdr_XGZj5sOzCMOQ4_0UoNXzxc4o8MU9BL6jhqMGWxnjhMxqINXhp3OElgtLeUFO_Yfiwqm3g1whFmZ2PFH2iqGmNmt32YDTqmZ3h6JRweSPqhxyKyGCfXV0WGdsd2xBXrKNLQ-0QBrjUyxJrWR8hNYBXBgSK9yTpHprNdrvd6_TBE71BpeHpZHSaw9Fw2B_os2r2DjNQau8XiLIpashUEzHaSeRh9-9dYf575IUE3LtO4AlXFJZxiMgSMyEuzJTjlttBt81sm81-tz8wR71-XLgcYfdbbu3msNcdtNvRz3pRR22uYb85HAx6nWF7OOi3B_m4jDbXEWVmm6uglOw2VwnwcZur5PiyotkRcU6b64j2RJvrmHdGm6vgGPYKvR7Uy3mE-allJiQ_zT2CZGb-pjm0igBKqlc8G38lG0hlff8OcWQ4YU_iO_IIcrklG_Y-Rp69fobN9wFRuoANSYbR-K78Jpv8D4Ry7N3BPREuhIxDjma07V615GGFuHrabJnHDfwhfonYvbtuLBH1sSKUd4CPz2XAFgcZY0obsJGw97HzJiS9Mkb9CGSg7Ra7zh6PVw9jA0X5nS2UkIMXX4wN8kHrnUoYfDGa1FnHkyOH4TJQACbRcNjpiLGL_hfyduN9QpeAXhxkpY5cIMyp0xTFSYj9dPVt9iwvPq053_qXrdb7-3tzi_iaLfEHVAhNm21aWwCBwp_lnvZZsG2N4XOzGsuPZNSKOF2pYxa_pb6JNMkjoLNycksMVFpdWEJcfGUc--KZuBl9uZJ7pg_e9PgXvPFvdrDqHsQcOliHoSkF9RxzNUvSmOj8x1F5DNz_Z4AoEZ5tp-8-q6Mql3mbuE8FrMCzIgNXHF93W2H68fOzejKmPGQmxEVuVu4MFTKIE7k4vClPosaJ1reI2r7Um7g2DRz85IZ5RKQ6RQuhmjh6E_0ZJ32klWIUy_l0BeqExF8oWyBqRRDpwHCJ7gtPPQlvJmnXK95sKfL-EThiAw0P9Sww3wpvxFyaYI4cWLStJw52aAljtCR7uNpP3uTKE5D0bSk682ZKU6nk75TrwmuBC3PUxt6YzWjMB1azWeDKvBWWEtqEi1AjWWuEcG6rUf7_O7ecy5KENMpHY7cdPopdl_lgz31Wre6zrLT7jlLofR9-EP8ehOE5VKIEdoV9XY98GV7C6pVxSkUicSkNKime3G3ApQLXjQ3x7Z-LYLkUR8kiqffk6fj9w8P97evT9_twd0tDpHo_3WCzEMel6ndSBc6x7H8YfrDw1eV14zvB71KRO3Acob4wBKVo6-N4e5GhJtScAi6Hm6R6JPEJdDavhEDP6f4De8KSP2AL9gjW6hU_P6GUEihSC5EN6LiJbFfPSJWqt7CXqjRDYymZpOu5iENt7XDEwxws5BGIaiWHT09YgovNBmY3WRJbpFP5Lhdbk6LKsYttQ_Vk73L8HbaY9Dxk-aBjoB7qwaoE0KHDpzlWleWH1qrqqR5-h22kHbt6qAfHmStz5fse2VxiqhxOX6HaEJMcFs2YUNEO0nr2nuKYRM_wha-xF6aMOk4TiFERSe7C8cgi4PplnKLIsZUsdjQWEs_0UHVyoxmDeJYTifZqGo1B0zR6VuoUQBvI8qCqNai1X9hozHFB2GPXmF89zTFCdMygGX_4OGeRyPg7fmPEUc1mzXI5IMsLGEy0DauykR306mwOW-rVOT5AQfVL6-_wqR7-jRORBmVwUelOISZiUVXjINZWNQ6vkODywMNnM5gdZiIJdpafg8Ttw0xw9DQvcoRdxbM5qN7n2XDZmj0bLeM_5NAYRpC7AcQ0OeuDB-4dGIPnrI2CrKRa2YEkGV0pXmorzBxpaY5qgYfvaeTFAEVyghHs5Y852WIxTvEx0SNGVPRLGa3G8Oh9lCrMRMMv2CLXidi9ZOXoiR8KWo9xH3jKBtyd6CtWtaGLN7sMRnq9rlpRVSdbc6LOChuKc-6Juvxvxjb_liWruArbRJ2wNQQZ9x0Bv3lyvkVyBOG_or7mlaywwz6VuI7bVHoGgY_Vi20_MNpCBS0QqeaS4JJuLM2gQOe7S2M2nt1fQNIolgmihvVoTJCNL26Zx1z4PoEq--LWQ0uOnUtDSLqYenhJPi6N_0D8W-HLdrP332dmIzp2HOyIk-HQXO_sEdw0_JkPECe9-4B8-vjM9gA0h2I6C_Tk2h5G4FBV4ckKrqOlFjWaeK0A_Eh-hafvp6mT95i7F2Fz79Kw2hdhUxOM_Dn-dyFnwwz_vjT6owso6yixiaBpyy6CcFPsL9EL1Lt1v01IGTegltlMF99mz2IOqq7BFwp1Mcxr8Ui1cFv5ACXGMBOIeQpyw2BFGuPFzvdhxqhBG70SMm-wOCzex1sl8DJPMDpnjNKYv6PtoejuOYwqDD_kYdXAI3tA_RoG1K9hQGfxyBqQWWZyZc3OTg0WseoaTZn59oghoeGV7JGx2PqVNbBKc6gsslOX_Xs1TAazhuVh1qBHt-RMqCvEWFVXZLcGA5bfM2oLsZ2q47cqLuFyCjg7Q_WFqsxBlVtU4ZC9sHuVOfTrcqtZV4wpPzWr27Fb2Ze9eiZVmcGPNwHFvIZI2KkhoHQqLspuRbxZj_3P3ilLT9puacQ5WVRFq_aqxuqa3NKtK7jUllefXUKVwM3EibtVOTRZ9figtp2ijoKve96Yyhq_-h5fU7LRq6xI9S2uXzYYVA0exwJV10e9OiI6isjBc9lN_IFFs8tXLUfZEpRvlDB3SVZhc1B9CduDEh_fMTjhFKdelUn3i9Jvljh777akXqm4Fe_NYOdF9uIXjFGM3LDd2Dpmg-LXnkqxmFJk4zWjDvZCRlg0ZMP3oaP3XAbt9gnA3h9lRLDOKdRBOzFBWlbXPCUx9d8dRLDeCUz672xizMmhxT3SUvolvdhSMNmgTBDDrp5-Ezc-xdva2MPOXL5GI5w-x3SZek-pV2CMpQ0Te28qjipipxdFlXeEmGOHJh2O-gUcUUpDMbMOxXSKzJKiUuY2k6cV4Cz_6GUyrYTwj-0YpTPRCE-vzhPIaKOKAH1zFP2BTxbGJytCX5byjBOUlAe1RZXc_8vAUjM_fhMiltU2u3lWXENI1xjxqhUHYnViJL_9cXHVOvyPb_4H_ezNAw==

The Dominating Blow skill has a simillar issue to the Absolution skill
where increasing count increases not only the "minion count" but also
applies a multiplier on the base skill damage.

This commit essentially copies
PathOfBuildingCommunity#4653 and
applies it to Dominating Blow.
@Paliak Paliak added the bug: accuracy Wording differences label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: accuracy Wording differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dominating blow missing "count once" when increasing count above 1
1 participant