Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the
FieldSet.add_constant()method from Parcels v4 as it is no longer necessary without JIT compilation. In v4, kernel functions can directly inherit variables from their enclosing scope, eliminating the need for an explicit method to add constants to the fieldset.The implementation maintains backward compatibility for internal use by keeping the
constantsdictionary and updating internal kernel initialization code to use direct dictionary assignment (fieldset.constants[key] = value) instead of the removed method. Warning messages were updated to guide users toward the new approach.Closes #2337.
The code in this pull request was generated by GitHub Copilot with the Claude Sonnet 4.5 model.
Checklist if Applicable
pytest tests