fix: issues when replying to comments #10912
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dschoordsch
requested changes
Feb 24, 2025
| const [initialContent] = useState(() => { | ||
| return replyingTo?.createdByUser && !!replyingTo?.threadParentId | ||
| return replyingTo?.createdByUser && replyingTo.createdByUser.id !== viewerId |
There was a problem hiding this comment.
-1 I don't quite get the new logic. Now if Bob wrote a top level message and I reply to it, I @mention Bob, even on if it's the first level reply.
I think it's always silly to @mention myself, but I think if I reply to the thread opener, there is no need to add the @mention either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10223
Demo: https://www.loom.com/share/971e6d96cdd947eb9629fdc7c9672914
This fixes three issues:
@Susanand ensure the cursor starts after@Susan. Currently, it's before.