Add isInvalidWorld to AsyncPlayerSpawnLocationEvent#13939
Open
NewwindServer wants to merge 3 commits into
Open
Add isInvalidWorld to AsyncPlayerSpawnLocationEvent#13939NewwindServer wants to merge 3 commits into
NewwindServer wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a world that players are in gets unloaded/reset, they end up spawning in the overworld at the same coordinates they were at.
This can cause players die suffocate in walls or fall to their death
There is no easy way to detect if a player spawn location has had its world changed, this patch fixes that by tracking if the world was determined to be invalid.
I added a constructor overload in-case some plugin author is manually creating AsyncPlayerSpawnLocationEvent instances for some reason.
I also removed
boolean[] invalidPlayerWorld = {false};local variable as it wasn't used for anything, let me know if you want it back.Also apologies that this isn't in per-file patch format, I could not get it working correctly.