Fix missing commands in plugins' HelpMap #13231
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
SimpleHelpMap#initializeCommands()was called twice on server startup:CraftServer#enablePlugins(PluginLoadOrder)if the load order was POSTWORLDMinecraftServer#initPostWorld()Bootstrap commands being registered on server boostrap meant they were already registered on the first
initializeCommandscall.JavaPlugin commands on the other hand, specifically brigadier commands registered using the LifeCycle event manager, are only registered before the second
initializeCommandscall.The issue is that the HelpMap was not cleared before the second call, and the second call could not register all plugins commands because the plugin was already there, and HelpMap topics works in a way that do not allow overrides.
This PR fixes the two issues mentionned above:
initializeCommandsbeing called twice on server startuponEnablebrigadier commands not being shown in/help <plugin>commandsFixes #13230