-
Notifications
You must be signed in to change notification settings - Fork 10
Even Better Parser #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lakesare
wants to merge
22
commits into
main
Choose a base branch
from
even-better-parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike we handle `rw`
Merged
d9df275
to
7bb1af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now I'm just merging changes from this branch one-by-one using this diff:
https://github.com/Paper-Proof/paperproof/compare/main..even-better-parser
I was pushing this to
main
, but parser requires more care than that 😅This PR:
rwa
/nth_rw
/etc.rw
rules handlingAs it stands, the new parser sort of works, but doesn't handle rewrites well in this Carleson's lemma e.g.
The way to proceed with this PR is to make
TEST.lean
work, add many test cases, and make sure each of them works when we change stuff.