Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support lower memory cards. #9804

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

support lower memory cards. #9804

wants to merge 2 commits into from

Conversation

ZHUI
Copy link
Collaborator

@ZHUI ZHUI commented Jan 21, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 35.35354% with 64 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (fb3e4c0) to head (1d8e6dc).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/deepseek_v2/modeling.py 0.00% 14 Missing ⚠️
paddlenlp/transformers/gemma/modeling.py 28.57% 10 Missing ⚠️
paddlenlp/transformers/qwen2/modeling.py 28.57% 10 Missing ⚠️
paddlenlp/transformers/qwen2_moe/modeling.py 28.57% 10 Missing ⚠️
paddlenlp/transformers/llama/modeling.py 35.71% 9 Missing ⚠️
paddlenlp/transformers/qwen/modeling.py 40.00% 9 Missing ⚠️
paddlenlp/datasets/dataset.py 84.61% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (35.35%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9804      +/-   ##
===========================================
+ Coverage    51.64%   52.20%   +0.56%     
===========================================
  Files          741      730      -11     
  Lines       119141   115865    -3276     
===========================================
- Hits         61525    60492    -1033     
+ Misses       57616    55373    -2243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants