Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XPU] Support empty_cache on XPUs #9789

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

will-jl944
Copy link
Contributor

@will-jl944 will-jl944 commented Jan 16, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

New features

PR changes

APIs

Description

Support empty_cache on XPUs

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 26.08696% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (13053a7) to head (d407728).
Report is 5 commits behind head on develop.

Current head d407728 differs from pull request most recent head 633f536

Please upload reports for the commit 633f536 to get more accurate results.

Files with missing lines Patch % Lines
...p/trainer/unified_checkpoint/unified_checkpoint.py 10.00% 9 Missing ⚠️
paddlenlp/utils/memory_utils.py 37.50% 5 Missing ⚠️
paddlenlp/quantization/quantization_utils.py 0.00% 2 Missing ⚠️
paddlenlp/trl/embedding_trainer.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9789      +/-   ##
===========================================
+ Coverage    52.06%   52.37%   +0.31%     
===========================================
  Files          734      731       -3     
  Lines       116591   115281    -1310     
===========================================
- Hits         60703    60379     -324     
+ Misses       55888    54902     -986     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DesmonDay
DesmonDay previously approved these changes Jan 21, 2025
Copy link
Contributor

@DesmonDay DesmonDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants