[Feature]support trainer_degree in name_mapping #2922
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gzy19990617
commented
Jul 18, 2025
gzy19990617
commented
|
Thanks for your contribution! |
gzy19990617
force-pushed
the
fix_vl_namemapping
branch
2 times, most recently
from
b4f20cf to
7e92f13
Compare
ZHUI
reviewed
Jul 21, 2025
fastdeploy/rl/rollout_model.py
Outdated
| @@ -192,7 +192,7 @@ def name(self) -> str: | |||
| """name""" | |||
| return "Ernie4_5_VLMoeForConditionalGenerationRL" | |||
|
|
|||
| def get_name_mappings_to_training(self) -> Dict[str, str]: | |||
| def get_name_mappings_to_training(self, trainer_degree=2) -> Dict[str, str]: | |||
| rollout_model_degree = self.fd_config.parallel_config.tensor_parallel_size | ||
| expert_num_per_rank = self.fd_config.model_config.moe_num_experts[0] // rollout_model_degree | ||
|
|
||
| expert_num_per_rank = self.fd_config.model_config.moe_num_experts[0] // trainer_degree |
There was a problem hiding this comment.
None 的情况下，trainer_degree = rollout_model_degree = self.fd_config.parallel_config.tensor_parallel_size 。 做一手兼容
gzy19990617
force-pushed
the
fix_vl_namemapping
branch
from
057b3a5 to
30a5b0b
Compare
gzy19990617
force-pushed
the
fix_vl_namemapping
branch
from
792473e to
529b221
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.