-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional pension systems #946
Conversation
@rickecon I'm running the full suite of tests locally tonight. If those pass, I believe this PR is ready to merge. |
With the latest commits, I only have 4 test failures locally:
These are expected as we know the optimizer for the tax function estimation returns difference results with difference version of Python/SciPy. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #946 +/- ##
==========================================
- Coverage 71.97% 71.40% -0.57%
==========================================
Files 19 20 +1
Lines 4732 4949 +217
==========================================
+ Hits 3406 3534 +128
- Misses 1326 1415 +89
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@jdebacker. I reviewed this PR and everything looks good. I just submitted a PR to your branch that updates the version number of OG-Core in |
Updated version and added numba to setup.py
@rickecon I just merged your PR. Thanks for thinking of those housekeeping items. |
This PR adds 3 additional pension systems (in additional the default US Social Security system):