Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry asset wait file processing timeouts #1150

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Split out coverage for update reference
  • Loading branch information
svevang committed Nov 5, 2024

Verified

This commit was signed with the committer’s verified signature.
svevang Sam Vevang
commit 7d7ead79f0cd4e831a19ce605be4c857935b3c1c
3 changes: 2 additions & 1 deletion test/factories/apple_episode_api_response.rb
Original file line number Diff line number Diff line change
@@ -15,13 +15,14 @@

after(:build) do |response_container, evaluator|
response_container["api_response"] =
{"request_metadata" => {"apple_episode_id" => evaluator.apple_episode_id, "item_guid" => evaluator.item_guid},
{"request_metadata" => {"apple_episode_id" => evaluator.apple_episode_id, "guid" => evaluator.item_guid},
"api_url" => evaluator.api_url,
"api_parameters" => {},
"api_response" => {"ok" => evaluator.ok,
"err" => evaluator.err,
"val" => {"data" => {"id" => "123",
"attributes" => {
"appleHostedAudioAssetContainerId" => nil,
"appleHostedAudioAssetVendorId" => evaluator.apple_hosted_audio_asset_container_id,
"publishingState" => evaluator.publishing_state,
"guid" => evaluator.item_guid,
6 changes: 5 additions & 1 deletion test/factories/apple_episode_factory.rb
Original file line number Diff line number Diff line change
@@ -6,7 +6,8 @@
# set up transient api_response
transient do
feeder_episode { create(:episode) }
api_response { build(:apple_episode_api_response) }
api_response { build(:apple_episode_api_response, item_guid: feeder_episode.item_guid) }
apple_hosted_audio_asset_container_id { "456" }
end

# set a complete episode factory varient
@@ -17,9 +18,12 @@
ep
end
transient do
apple_hosted_audio_asset_container_id { "456" }
api_response do
build(:apple_episode_api_response,
publishing_state: "PUBLISH",
item_guid: feeder_episode.item_guid,
apple_hosted_audio_asset_container_id: apple_hosted_audio_asset_container_id,
apple_hosted_audio_state: Apple::Episode::AUDIO_ASSET_SUCCESS)
end
end
17 changes: 17 additions & 0 deletions test/models/apple/publisher_test.rb
Original file line number Diff line number Diff line change
@@ -527,4 +527,21 @@
end
end
end

describe "#update_audio_container_reference!" do
let(:episode) { build(:uploaded_apple_episode, show: apple_publisher.show, apple_hosted_audio_asset_container_id: nil) }

it "updates container references for episodes" do
assert episode.has_unlinked_container?

mock_result = episode.apple_sync_log.api_response.deep_dup
mock_result["api_response"]["val"]["data"]["attributes"]["appleHostedAudioAssetContainerId"] = "456"

apple_publisher.api.stub(:bridge_remote_and_retry, [[mock_result], []]) do
apple_publisher.update_audio_container_reference!([episode])
end

refute episode.has_unlinked_container?
end
end
end