[RPC][TierTwo][Bug] Initialize un-initialized MNsInfo member total#2576
Closed
Fuzzbawls wants to merge 2 commits intoPIVX-Project:masterfrom
Closed
[RPC][TierTwo][Bug] Initialize un-initialized MNsInfo member total#2576Fuzzbawls wants to merge 2 commits intoPIVX-Project:masterfrom
Fuzzbawls wants to merge 2 commits intoPIVX-Project:masterfrom
Conversation
|
This is already covered in #2565, test included. |
|
Covered in another PR. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #2554 that leaves the
totalmember ofMNsInfoun-initialized by default, resulting in incorrect return results for thegetmasternodecountRPC command.Also added regression tests to exercise this command, slightly increasing code coverage