[BLS] Add wrapper around chiabls lib, worker, benchmarks and unit tests by random-zebra · Pull Request #2420 · PIVX-Project/PIVX

random-zebra · 2021-06-14T14:01:39Z

Based on top of:

[Build] Add chiabls subtree #2419

This reworks #2405, adapting the commits to the new build system (which includes the library already at v1.0.1, as git subtree).

random-zebra · 2021-07-28T20:56:53Z

Rebased on master. Ready for review.

furszy

Code reviewed up to 32121d35.
So far, so good ☕ ☕. Left two comments in the BLS IES area.

Plus added test coverage for the basic encryption and decryption scheme here furszy@8b8c223. If you want to cherry-pick It, all yours.

First stop before jumping into the thread pool workers and DKG bench waters.

src/bls/bls_ies.cpp

random-zebra · 2021-09-07T12:00:00Z

Thanks @furszy . Rebased on master and picked your test, only reworking it using CBLSIESEncryptedObject<std::string> instead of CBLSIESEncryptedBlob directly (in case we want to keep this code).

Inspired by this, have also added encryption/decryption (with CBLSIESMultiRecipientObjects<CBLSSecretKey>) for the contribution shares in the DKG test.

furszy

Reviewed till a24d9bad01372b3295dd16634a680a6684ac95b5.
Few more comments, nothing biggie.

src/bls/bls_worker.cpp

furszy

Review completed, the DKG test made me feel at home ☕ . Code ACK 21d2f247d760bf748f83c5d154addf0b3c44edd4.
Left few more comments, nothing blocking. Can squash the changes and it's ready to go for me.

src/bench/bls.cpp

src/test/bls_tests.cpp

>>> backports dash@47a162255260019bd4733d4336c235b01019df9f A simple C++ thread pool library https://github.com/vit-vit/CTPL Commit: 437e135dbd94eb65b45533d9ce8ee28b5bd37b6d

to avoid conflicts with pre-processor's constants defined by relic_conf

schemes (IES)

Also fix review nits: - replace hardware_concurrency() with GetNumCores() - remove code duplication for (Async)VerifyContributionShare

std::random_shuffle is deprecated in C++14 and will be removed in C++17

random-zebra · 2021-09-14T13:57:27Z

Rebased and squashed.

furszy

one step closer, ACK 0d126ee

Fuzzbawls

ACK 0d126ee

d3843cd [Refactor] No need to get the publickey of the active masternode (random-zebra) 483f509 [Refactor] De-duplicate operator BLS key parsing in rpc (random-zebra) 855c094 [Build] Fix CMake builds with chiabls/relic includes (random-zebra) 77ec208 [Tests] Fix TierTwo functional tests with BLS operator key (random-zebra) dd46f72 [TierTwo] Migration of DMN operator key to BLS (random-zebra) 1dfdcc1 [RPC] Implement generateblskeypair() RPC command (random-zebra) 619c0f8 scripted-diff: Rename keyIDOperator to pubKeyOperator (random-zebra) b0a7fa5 [QA] Add tests for fbv messages signed with BLS keys (random-zebra) dd0fb01 [TierTwo] Add functions to sign/verify messages with BLS (random-zebra) Pull request description: This builds on top of: - [x] #2363 - [x] #2419 - [x] #2420 As per title, introduce BLS keys/signatures for messages signed by the masternode operator (which is a requirement for [DIP 6](https://github.com/dashpay/dips/blob/master/dip-0006.md), and subsequent upgrades). - a new RPC command `generateblskeypair` returns a new publickey/secretkey BLS keypair. - `CDeterministicMNState::keyIDOperator` is now a `CBLSLazyPublicKey` (instead of a `CKeyID`), and it's renamed `pubKeyOperator`. - `-mnoperatorprivatekey` flag takes a BLS secret key in hex format. - `CActiveMasternodeInfo` stores a `CBLSPublicKey`/`CBLSSecretKey` - the BLS signature byte vector is serialized for legacy messages (mnw, fbv) in the compatibility code. ACKs for top commit: furszy: great, ACK d3843cd Fuzzbawls: ACK d3843cd Tree-SHA512: 1caf49615283d10b356caa049b57091dc70805c0bf2c11645d560c81223ce0d9936a46096cc4871c5ec25164518ebdf259d0f23a8c5bca39f2e436cc9e954519

random-zebra added Tests Util / log / libs Upstream Dash labels Jun 14, 2021

random-zebra added this to the 6.0.0 milestone Jun 14, 2021

random-zebra self-assigned this Jun 14, 2021

random-zebra mentioned this pull request Jun 14, 2021

[Refactor] MN operator key migration to BLS #2421

Merged

3 tasks

Fuzzbawls mentioned this pull request Jun 24, 2021

[Build] Add chiabls subtree #2419

Merged

random-zebra force-pushed the 202106_bls-wrapper branch 2 times, most recently from 9f087cd to 5a6d14e Compare July 28, 2021 20:52

random-zebra force-pushed the 202106_bls-wrapper branch 2 times, most recently from 09edb1a to ad10b65 Compare July 30, 2021 10:59

furszy modified the milestones: 5.3.0, 6.0.0 Jul 30, 2021

random-zebra force-pushed the 202106_bls-wrapper branch 2 times, most recently from b86ab3a to 1d48ccf Compare September 3, 2021 12:33

furszy reviewed Sep 6, 2021

View reviewed changes

src/bls/bls_ies.cpp Outdated Show resolved Hide resolved

src/bls/bls_ies.cpp Outdated Show resolved Hide resolved

random-zebra force-pushed the 202106_bls-wrapper branch 3 times, most recently from 100ebc5 to 7acc769 Compare September 7, 2021 11:47

furszy reviewed Sep 8, 2021

View reviewed changes

src/bls/bls_worker.cpp Outdated Show resolved Hide resolved

src/bls/bls_worker.cpp Outdated Show resolved Hide resolved

src/bls/bls_worker.cpp Outdated Show resolved Hide resolved

furszy reviewed Sep 13, 2021

View reviewed changes

src/bench/bls.cpp Outdated Show resolved Hide resolved

src/bench/bls.cpp Outdated Show resolved Hide resolved

src/test/bls_tests.cpp Outdated Show resolved Hide resolved

src/test/bls_tests.cpp Outdated Show resolved Hide resolved

random-zebra and others added 7 commits September 14, 2021 13:39

Add ctpl header only library

9f9a3d7

>>> backports dash@47a162255260019bd4733d4336c235b01019df9f A simple C++ thread pool library https://github.com/vit-vit/CTPL Commit: 437e135dbd94eb65b45533d9ce8ee28b5bd37b6d

Add helper to rename all threads of a ctpl::thread_pool

d9ffaa6

[Trivial] Rename BCLog::BENCH/RAND to BCLog::BENCHMARK/RANDOM

dbb0305

to avoid conflicts with pre-processor's constants defined by relic_conf

Add pooled_secure_allocator and mt_pooled_secure_allocator

a0b04c1

Implement wrappers around Chia BLS libs

6f1d0e2

Add simple helpers/wrappers for BLS+AES based integrated encryption

df56dea

schemes (IES)

Add highly parallelized worker/helper for BLS/DKG calculations

225c8a8

random-zebra and others added 13 commits September 14, 2021 13:41

[Trivial] bls_worker: Fix members initialization order in Aggregators

7bb9f02

Also fix review nits: - replace hardware_concurrency() with GetNumCores() - remove code duplication for (Async)VerifyContributionShare

Add BLS and DKG benchmarks

9502597

[Trivial] Remove unused variables in bls bench test

1c3f2cb

[BUG] Initialize Random for bench tests

5b16d89

Add ECDSA benchmarks

f5c0870

Bail out early from secure deallocation

104c4b0

[Refactor] Initialize BLS allocator in BasicTestingSetup

c4c6efe

[QA] Add test for BLS sign/verify message and sethexstr

0253ea7

[QA] Add unit test for DKG using wrapper/worker

9f4ac39

[Refactoring] Replace std::random_shuffle with Shuffle

aa51751

std::random_shuffle is deprecated in C++14 and will be removed in C++17

Test: Add bls ies basic encryption and decryption test coverage.

0453474

[QA] Refactor bls_ies_tests using CBLSIESEncryptedObject

db69885

[QA] Test encryption/decryption of sk shares in dkg unit test

0d126ee

random-zebra force-pushed the 202106_bls-wrapper branch from 21d2f24 to 0d126ee Compare September 14, 2021 13:52

random-zebra requested a review from Fuzzbawls September 14, 2021 13:57

furszy approved these changes Sep 14, 2021

View reviewed changes

Fuzzbawls approved these changes Sep 17, 2021

View reviewed changes

random-zebra merged commit a589449 into PIVX-Project:master Sep 17, 2021

Fuzzbawls modified the milestones: 6.0.0, 5.5.0 Sep 11, 2022

Fuzzbawls modified the milestones: 5.5.0, 6.0.0 Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BLS] Add wrapper around chiabls lib, worker, benchmarks and unit tests#2420

[BLS] Add wrapper around chiabls lib, worker, benchmarks and unit tests#2420
random-zebra merged 20 commits intoPIVX-Project:masterfrom
random-zebra:202106_bls-wrapper

random-zebra commented Jun 14, 2021 •

edited

Loading

Uh oh!

random-zebra commented Jul 28, 2021

Uh oh!

furszy left a comment

Uh oh!

Uh oh!

Uh oh!

random-zebra commented Sep 7, 2021

Uh oh!

furszy left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

furszy left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

random-zebra commented Sep 14, 2021

Uh oh!

furszy left a comment

Uh oh!

Fuzzbawls left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

random-zebra commented Jun 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

random-zebra commented Jul 28, 2021

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

random-zebra commented Sep 7, 2021

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

random-zebra commented Sep 14, 2021

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

Fuzzbawls left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

random-zebra commented Jun 14, 2021 •

edited

Loading