[RPC] Implement generatetoaddress RPC command#2297
Merged
random-zebra merged 3 commits intoPIVX-Project:masterfrom May 13, 2021
Merged
[RPC] Implement generatetoaddress RPC command#2297random-zebra merged 3 commits intoPIVX-Project:masterfrom
random-zebra merged 3 commits intoPIVX-Project:masterfrom
Conversation
random-zebra
previously approved these changes
Apr 17, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
LGTM. Would be good to use this new RPC in some functional test, but we can add it later. utACK 16d95dd4b6b34df5c381483851ad4bb1c0c62f60
Fuzzbawls
requested changes
May 11, 2021
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
needs a small change to avoid parsing errors, and could fixup a couple styling nits while at it.
furszy
force-pushed
the
2021_implement_generatetoaddress
branch
from
16d95dd to
d6df233
Compare
Author
|
Updated per review 👍 |
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
This has conflicts with #2337.
But I'm ok if we want to give priority to this one, as it's straight forward (and it was submitted earlier 😉 )
furszy
force-pushed
the
2021_implement_generatetoaddress
branch
from
d6df233 to
4fe3b03
Compare
Author
|
Updated per feedback. |
Fuzzbawls
approved these changes
May 12, 2021
random-zebra
added
the
Needs Release Notes
random-zebra
removed
the
Needs Release Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a new RPC command
generatetoaddress. Useful mostly for functional testing and a good number of updates that are coming from upstream.