Skip to content

fix: do not trigger XML Reader Undefined array key "x" #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
+112 −2
Merged

fix: do not trigger XML Reader Undefined array key "x" #4669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PhpSpreadsheet/Reader/Xml/Style.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public function parseStyles(SimpleXMLElement $xml, array $namespaces): array
break;
case 'Protection':
$locked = $hidden = null;
$styleAttributesP = $styleData->attributes($namespaces['x']);
$styleAttributesP = array_key_exists('x', $namespaces) ? $styleData->attributes($namespaces['x']) : [];
if (isset($styleAttributes['Protected'])) {
$locked = ((bool) (string) $styleAttributes['Protected']) ? Protection::PROTECTION_PROTECTED : Protection::PROTECTION_UNPROTECTED;
}
Expand Down
3 changes: 2 additions & 1 deletion tests/PhpSpreadsheetTests/Reader/Xls/XlsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace PhpOffice\PhpSpreadsheetTests\Reader\Xls;

use PhpOffice\PhpSpreadsheet\Cell\Cell;
use PhpOffice\PhpSpreadsheet\IOFactory;
use PhpOffice\PhpSpreadsheet\Reader\Xls;
use PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional;

Expand Down Expand Up @@ -92,7 +93,7 @@ public function testLoadXlsBug1592(): void
public function testLoadXlsBug1114(): void
{
$filename = 'tests/data/Reader/XLS/bug1114.xls';
$spreadsheet = \PhpOffice\PhpSpreadsheet\IOFactory::load($filename);
$spreadsheet = IOFactory::load($filename);
$sheet = $spreadsheet->getActiveSheet();
self::assertSame(1148140800.0, $sheet->getCell('B2')->getValue());
$spreadsheet->disconnectWorksheets();
Expand Down
21 changes: 21 additions & 0 deletions tests/PhpSpreadsheetTests/Reader/Xml/XmlTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace PhpOffice\PhpSpreadsheetTests\Reader\Xml;

use PhpOffice\PhpSpreadsheet\Cell\DataType;
use PhpOffice\PhpSpreadsheet\IOFactory;
use PhpOffice\PhpSpreadsheet\Reader\Exception as ReaderException;
use PhpOffice\PhpSpreadsheet\Reader\Xml;
use PHPUnit\Framework\TestCase;
Expand Down Expand Up @@ -102,4 +103,24 @@ public function testEmptyFilename(): void
$this->expectExceptionMessage('File "" does not exist');
$xmlReader->load('');
}

/**
* Ensures that a PHP warning for `Undefined array key "x"` is not triggered.
*
* Relies on PHPUnit's conversion of PHP warnings, deprecations, and notices to exceptions.
* If that warning occurs, the test should fail.
*/
public function testLoadXlsBug4669(): void
{
$filename = 'tests/data/Reader/Xml/bug4669.xml';

$reader = IOFactory::createReaderForFile($filename);
$reader->setReadDataOnly(true);

$spreadsheet = $reader->load($filename);

$sheet = $spreadsheet->getActiveSheet();
self::assertSame('Report Date', $sheet->getCell('A1')->getValue());
$spreadsheet->disconnectWorksheets();
}
}
88 changes: 88 additions & 0 deletions tests/data/Reader/Xml/bug4669.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
<?xml version="1.0" encoding="UTF-8"?>
<Workbook xmlns="urn:schemas-microsoft-com:office:spreadsheet" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:html="http://www.w3.org/TR/REC-html40" xmlns:ss="urn:schemas-microsoft-com:office:spreadsheet">
<Styles>
<Style ss:ID="Default" ss:Name="Normal">
<Alignment ss:Vertical="Bottom"/>
<Borders/>
<Font ss:FontName="Verdana"/>
<Interior/>
<NumberFormat/>
<Protection/>
</Style>
<Style ss:ID="s22">
<NumberFormat ss:Format="General Date"/>
</Style>
<Style ss:ID="s66">
<NumberFormat ss:Format="Fixed"/>
</Style>
</Styles>
<Worksheet ss:Name="stats by transaction_notes">
<Table>
<Row>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Report Date</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Trx Date</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Merchant</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Terminal</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Report Type</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Transition</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Report Message</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Report Info</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Status</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Merchant Transaction ID</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Unique ID</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Reference Transaction ID</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Reference Transaction Type</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Currency</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Amount (in minor currency unit)</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Card Holder</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Card Brand</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Card Number</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Email</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Country</Data>
</Cell>
<Cell ss:StyleID="Default">
<Data ss:Type="String">Remote IP</Data>
</Cell>
</Row>
</Table>
</Worksheet>
</Workbook>