Re-implement ASC function and add unit tests #4513
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-implements the `ASC` spreadsheet function, which converts full-width (double-byte) characters to their corresponding half-width (single-byte) characters. This work is being recommitted to a new branch to incorporate recent updates from the master branch. The implementation resides in the `TextData` class, and the `Calculation` class has been updated to delegate calls to `ASC` to this implementation. Unit tests have been included in `TextDataTest.php` to cover various scenarios: - Full-width alphanumeric characters. - Full-width symbols. - Mixed full-width and half-width characters. - Empty strings. - Boolean and numeric inputs. - Japanese Katakana and Hiragana characters.
|
I thought I posted this earlier, but I don't see it. So I'll try again. I assume you will be able to straighten out your change so that it only changes a few members instead of the 3,121 (!) this affects. But, before you do, I'm interested in one of your test cases. Here's what I see when I try this in Excel: The output seems to match the input; it hasn't been changed from full-width to half-width. There may be many possible explanations for why this doesn't agree with your test case, including font or system options. Do you have any explanation for why my Excel doesn't match your expectation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-implements the
ASCspreadsheet function, which converts full-width (double-byte) characters to their corresponding half-width (single-byte) characters. This work is being recommitted to a new branch to incorporate recent updates from the master branch.The implementation resides in the
TextDataclass, and theCalculationclass has been updated to delegate calls toASCto this implementation.Unit tests have been included in
TextDataTest.phpto cover various scenarios:This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.