Skip to content

Add exclude directive for maybe-ASP-open rule #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add exclude directive for maybe-ASP-open rule #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions PHPCompatibilityMagento/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<rule ref="PHPCompatibility">
<!-- https://github.com/magento/magento2/.... -->
<!-- TODO: add Magento specific excludes with a link to the file in which they are contained. -->
<exclude name="PHPCompatibility.Miscellaneous.RemovedAlternativePHPTags.MaybeASPOpenTagFound" />
</rule>

<!-- https://github.com/magento/magento2/blob/2.4-develop/composer.json -->
Expand Down
8 changes: 8 additions & 0 deletions Test/MagentoTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,11 @@
*/

// TODO: add a test for each polyfilled feature (violations for which are excluded via the ruleset).

// Magento's template syntax uses <% and %> as a delimiter. These should not be confused with ASP open/close tags.
// @see https://github.com/magento/magento2/blob/2.4.6/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/attribute/steps/bulk.phtml#L108-L109
?>
<script data-template="test" type="text/x-magento-template">
<div id="<%- data.id %>" class="file-row">
</div>
</script>