Skip to content

Conversation

@stepps00
Copy link
Collaborator

@stepps00 stepps00 commented Nov 7, 2025

Adjusts the land_cover license type and fixes a typo in boundary_division.

Copy link
Contributor

@jenningsanderson jenningsanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, except I think we need to change place to include apache now, right?

@stepps00
Copy link
Collaborator Author

stepps00 commented Nov 10, 2025

Good call - the most recent commit adjusts TYPE_LICENSE_MAP to include both place license types and adds logic to properly pull out the license value.

edit: this is failing the test_license_values_are_strings test, as my commit adjusts the places license value to be a list.
I can revert that change if we have another way to handle both license types, or we can remove that test.

=================================== FAILURES ===================================
_______________________ test_license_values_are_strings ________________________

    def test_license_values_are_strings():
        """Test that all license values are strings."""
        for license_value in TYPE_LICENSE_MAP.values():
>           assert isinstance(license_value, str)
E           AssertionError: assert False
E            +  where False = isinstance(['CDLA-Permissive-2.0', 'Apache-2.0'], str)

tests/test_overture_stac.py:23: AssertionError
=========================== short test summary info ============================
FAILED tests/test_overture_stac.py::test_license_values_are_strings - AssertionError: assert False
 +  where False = isinstance(['CDLA-Permissive-2.0', 'Apache-2.0'], str)
========================= 1 failed, 7 passed in 20.49s =========================
22s
Run pytest
============================= test session starts ==============================
platform linux -- Python 3.11.14, pytest-9.0.0, pluggy-1.6.0 -- /opt/hostedtoolcache/Python/3.11.14/x64/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/stac/stac
configfile: pyproject.toml
testpaths: tests
collecting ... collected 8 items

tests/test_overture_stac.py::test_license_map_exists PASSED              [ 12%]
tests/test_overture_stac.py::test_common_types_have_licenses PASSED      [ 25%]
tests/test_overture_stac.py::test_license_values_are_strings FAILED      [ 37%]
tests/test_registry_manifest.py::test_init_default_params PASSED         [ 50%]
tests/test_registry_manifest.py::test_init_custom_params PASSED          [ 62%]
tests/test_registry_manifest.py::test_manifest_sorting PASSED            [ 75%]
tests/test_registry_manifest.py::test_manifest_format PASSED             [ 87%]
tests/test_registry_manifest.py::test_create_registry_manifest_integration PASSED [100%]

=================================== FAILURES ===================================
_______________________ test_license_values_are_strings ________________________

    def test_license_values_are_strings():
        """Test that all license values are strings."""
        for license_value in TYPE_LICENSE_MAP.values():
>           assert isinstance(license_value, str)
E           AssertionError: assert False
E            +  where False = isinstance(['CDLA-Permissive-2.0', 'Apache-2.0'], str)

tests/test_overture_stac.py:23: AssertionError
=========================== short test summary info ============================
FAILED tests/test_overture_stac.py::test_license_values_are_strings - AssertionError: assert False
 +  where False = isinstance(['CDLA-Permissive-2.0', 'Apache-2.0'], str)
========================= 1 failed, 7 passed in 20.49s =========================
Error: Process completed with exit code 1.
0s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants