add required JVM args for Loader to profile json #6
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostLuma
reviewed
Sep 8, 2025
| if (generation >= 2) { | ||
| jvmArgs.add("-Dfabric.fixPackageAccess"); | ||
| } | ||
| jvmArgs.add("-Dfabric.gameVersion"); |
There was a problem hiding this comment.
This argument needs to be -Dloader.gameVersion when running on Quilt, otherwise it will have no effect.
There was a problem hiding this comment.
thanks for pointing that out! is the same not true for the other arg?
There was a problem hiding this comment.
I'm not sure an equivalent exists there, which is why I did not mention it:
https://github.com/QuiltMC/quilt-loader/blob/develop/src/main/java/org/quiltmc/loader/impl/util/SystemProperties.java
There was a problem hiding this comment.
oh? I guess not all features carry over then...
|
gonna wait until QuiltMC/quilt-loader/pull/479 is merged and then update this PR appropriately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Dfabric.fixPackageAccessis only required for gen2, since that intermediary enforces the target package which trips some versions up-Dfabric.gameVersionis relevant for gen1 too, in order to make Infdev versions use the correct version