Skip to content

remove vault calls to the Dripper when doing rebases #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 15, 2025

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Jun 20, 2025

This PR removes VaultCore calls to the dripper when doing rebases. Also Dripper is no longer set on the Vault on deploys of mocks.

Current state of Vault, Dripper and Harvester configuration:
OUSD:

OETH:

OETHb:

OETHp:

Copy link

github-actions bot commented Jun 20, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 379ebf9

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.58%. Comparing base (1df67ff) to head (379ebf9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2540      +/-   ##
==========================================
- Coverage   40.58%   40.58%   -0.01%     
==========================================
  Files         111      111              
  Lines        5312     5303       -9     
  Branches     1407     1405       -2     
==========================================
- Hits         2156     2152       -4     
+ Misses       3153     3149       -4     
+ Partials        3        2       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sparrowDom sparrowDom marked this pull request as ready for review June 20, 2025 23:03
shahthepro
shahthepro previously approved these changes Jul 3, 2025
Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

naddison36
naddison36 previously approved these changes Jul 7, 2025
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparrowDom sparrowDom dismissed stale reviews from naddison36 and shahthepro via 236681c July 14, 2025 14:42
@sparrowDom sparrowDom merged commit ca789c9 into master Jul 15, 2025
11 of 16 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/removeDripper branch July 15, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants