-
Notifications
You must be signed in to change notification settings - Fork 88
remove vault calls to the Dripper when doing rebases #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
- Coverage 40.58% 40.58% -0.01%
==========================================
Files 111 111
Lines 5312 5303 -9
Branches 1407 1405 -2
==========================================
- Hits 2156 2152 -4
+ Misses 3153 3149 -4
+ Partials 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes VaultCore calls to the dripper when doing rebases. Also Dripper is no longer set on the Vault on deploys of mocks.
Current state of Vault, Dripper and Harvester configuration:
OUSD:
collectAndRebase
is being called by Defender ActionOETH:
OETHb:
OETHp: