Add deployment file for Bridged wOETH Strategy #2496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahthepro
requested review from
sparrowDom,
DanielVF,
naddison36 and
clement-ux
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
- Coverage 41.08% 40.89% -0.19%
==========================================
Files 100 101 +1
Lines 4688 4707 +19
Branches 1237 1242 +5
==========================================
- Hits 1926 1925 -1
- Misses 2760 2780 +20
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shahthepro
changed the title
clement-ux
reviewed
Apr 28, 2025
There was a problem hiding this comment.
- All deployed contracts are listed in the deploy PR's description
- OETHPlumeOracleRouter
- BridgedWOETHStrategyProxy
- BridgedWOETHStrategy
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- OETHPlumeOracleRouter: No constructor
- BridgedWOETHStrategyProxy: No constructor
- BridgedWOETHStrategy: [address(0), Vault], WETH, BridgedWOETH, OETH
- The transactions that interacted with the newly deployed contract match the deploy script.
- OETHPlumeOracleRouter: Cache decimals
- BridgedWOETHStrategyProxy: initialize
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
| feedAddress = FIXED_PRICE; | ||
| maxStaleness = 0; | ||
| } else if (asset == WOETH) { | ||
| // Chainlink: https://data.chain.link/feeds/base/base/woeth-oeth-exchange-rate |
There was a problem hiding this comment.
nit: this should be from plume chain, but not a big deal.
|
Everything looks good, but I cannot verify:
|
sparrowDom
reviewed
Apr 28, 2025
| address constant WOETH = 0xD8724322f44E5c58D7A815F542036fb17DbbF839; | ||
| // Ref: https://docs.eo.app/docs/eprice/feed-addresses/plume | ||
| address constant WOETH_ORACLE_FEED = | ||
| 0x4915600Ed7d85De62011433eEf0BD5399f677e9b; |
There was a problem hiding this comment.
Is this a trustworthy feed? How high is our confidence in this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Change Checklist
To be completed before internal review begins:
Internal review:
Deploy checklist
Two reviewers complete the following checklist: