-
Notifications
You must be signed in to change notification settings - Fork 83
Deploy WrappedOusd and Vault upgrades - Mainnet #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2493 +/- ##
==========================================
+ Coverage 42.57% 43.38% +0.81%
==========================================
Files 100 100
Lines 4688 4688
Branches 1237 1237
==========================================
+ Hits 1996 2034 +38
+ Misses 2690 2652 -38
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- VaultCore
- VaultAdmin
- WrappedOusd
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- VaultCore: No constructor
- VaultAdmin: No constructor
- WrappedOusd: OUSD Proxy
- The transactions that interacted with the newly deployed contract match the deploy script.
- No interaction with deployed contracts.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Contract Diff
sol2uml diff 0x6b89f2410c45701E1456f9e2c5C3f8fAB5137B7A .,node_modules
sol2uml diff 0xdfA729E70A0f0182E9e6066B6F6Ec4392c1AC39F .,node_modules
sol2uml diff 0xdeABEB7DFdA1dEFf8a90fDe8A16D7A42D316E632 .,node_modules
(node:34309) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "VaultCore" contract with address 0x6b89f2410c45701E1456f9e2c5C3f8fAB5137B7A on mainnet
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/math/SafeCast.sol
match @openzeppelin/contracts/utils/math/SafeMath.sol
match contracts/governance/Governable.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IDripper.sol
match contracts/interfaces/IGetExchangeRateToken.sol
match contracts/interfaces/IOracle.sol
match contracts/interfaces/IStrategy.sol
match contracts/token/OUSD.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/StableMath.sol
match contracts/vault/VaultCore.sol
match contracts/vault/VaultInitializer.sol
match contracts/vault/VaultStorage.sol
(node:34315) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "VaultAdmin" contract with address 0xdfA729E70A0f0182E9e6066B6F6Ec4392c1AC39F on mainnet
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/math/SafeCast.sol
match @openzeppelin/contracts/utils/math/SafeMath.sol
match contracts/governance/Governable.sol
match contracts/interfaces/IBasicToken.sol
match contracts/interfaces/IOracle.sol
match contracts/interfaces/IStrategy.sol
match contracts/interfaces/ISwapper.sol
match contracts/interfaces/IVault.sol
match contracts/token/OUSD.sol
match contracts/utils/Helpers.sol
match contracts/utils/Initializable.sol
match contracts/utils/StableMath.sol
match contracts/vault/VaultAdmin.sol
match contracts/vault/VaultStorage.sol
(node:34319) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "WrappedOusd" contract with address 0xdeABEB7DFdA1dEFf8a90fDe8A16D7A42D316E632 on mainnet
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/ERC20.sol
match @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol
match @openzeppelin/contracts/utils/Address.sol
match @openzeppelin/contracts/utils/Context.sol
match @openzeppelin/contracts/utils/math/SafeCast.sol
match contracts/governance/Governable.sol
match contracts/token/OETH.sol
match contracts/token/OUSD.sol
match contracts/token/WOETH.sol
match contracts/token/WrappedOusd.sol
match contracts/utils/Initializable.sol
match lib/openzeppelin/contracts/token/ERC20/extensions/ERC4626.sol
match lib/openzeppelin/interfaces/IERC4626.sol
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Description
Code Changes
Deployment script
contracts/deploy/mainnet/135_vault_wousd_upgrade.js
Contracts
Contract differences
Governance
Governance proposal: 62736766423374672768580940310861921323283907575465980811344596309308068769219
Deploy checklist
Two reviewers complete the following checklist: