Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#264] Add component checkbox #456

Open
wants to merge 43 commits into
base: develop
Choose a base branch
from
Open

[#264] Add component checkbox #456

wants to merge 43 commits into from

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Feb 17, 2025 •
edited
Loading

Related issues

#264

Description

Implement checkbox component with its two variants (selector only and control item)

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I checked my changes do not add new SwiftLint warnings
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • Design review has been done
  • Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues
  • The wiki has been updated if needed (optional)

pylapp added 30 commits February 6, 2025 12:08
@pylapp
chore: duplicate implementation of switch for checkbox component (#264)
4555919 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: duplicate presentation of switch for checkbox in design toolbox (
ff6c8e5 
#264)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: management of three states of checkbox component (#264)
68eb008 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: add fake tokens, refactor names, improve styles of selector (#264
e123b99 
)

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update design toolbox, manage states and init (#264)
04e10bb 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: better manage of state object for checkbox VM
3bda363 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update doc, add icon for demo app, refactor of properties (#264)
210a0ba 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: add in design toolbox text fields for checkbox demo (#264)
4acf01e 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: stack items to top for long texts dispay (#264)
8547bb8 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: add tick and dash images for selector (#264)
dc1d80d 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore(🤖): update CheckRadioComponentTokens
8952f5d 
Tokens library version v0.5.0

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: apply tokens for selector (#264)
1bfe95d 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: manage centering of items in label (#264)
fe1384f 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: add read only status (#264)
16e9420 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: more management of colors (#264)
a2de230 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: add read only status (#264)
a40211c 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: more management of colors (#264)
bfe75a3 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: rename label to labelText (#264)
67f0589 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: add more spacing token (#264)
ccc0191 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update configuration of checkbox (#264)
3ac24be 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update card ind esign toolbox (#264)
6ab6176 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
feat: vocalization of component (#264)
2649d63 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: clean up after batch of cherry-picks (#264)
3eb7f25 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: clean up, add tests (#264)
ab55f1e 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: update CHANGELOG
cb4fd25 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
chore: apply comments of review (#264)
230bcff 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: introduction of checkbox in Design Toolbox page (#264)
c557cf2 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: split API for checkbox (#264)
7833e54 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): width of borders (#264)
24fe9bb 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor(review): spacing in texts of label (#264)
30a0fd1 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp and others added 9 commits February 12, 2025 17:30
@pylapp
test: update snapshots (#264)
91a4e89 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: documentation with new API (#264)
463cbcc 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix: missing wordings (#264)
d8f762c 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
fix: CHANGELOG
d503ab1 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: rename objects related to checkbox (#264, #453)
8edf80e 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@ludovic35
Create an internal component ControlItem and use it in CheckboxContro…
95ed7c4 
…lItem
@ludovic35
Use rigth element in app, adjust icon position, and add text edition …
bf26554 
…area
@pylapp
refactor: keep only v2 version of component (#264)
5e6c837 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: update Design Toolbox (#264)
a523a94 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp requested a review from ludovic35 as a code owner February 17, 2025 13:13
@pylapp pylapp marked this pull request as draft February 17, 2025 13:13
@pylapp pylapp linked an issue Feb 17, 2025 that may be closed by this pull request
[Component] Create component - Checkbox #264
Open
32 tasks
pylapp and others added 4 commits February 17, 2025 14:54
@pylapp
refactor: UI tests (#264)
cbfeec1 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
refactor: demo app, tests (#264)
ce742c3 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp @boosted-bot
refactor(🤖): partial integration of tokens version 0.6.0 (#458)
3069329 
Tokenator generation 20250218081142
Tokens library version 0.6.0

WARNING: Partial integration as tokenator is not able to manage all the tokens with a lot of troubles

Assisted-by: GPT-4o-mini (Dinootoo)
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: boosted-bot <[email protected]>
@pylapp
refactor: apply tokens v0.6.0 (#264)
0f595b1 
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp marked this pull request as ready for review February 18, 2025 11:49
@pylapp pylapp added the ⌛ waiting for validations The issue associated to this pull request is being reviewed by PO / a11y tea design team label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovic35 ludovic35 Awaiting requested review from ludovic35 ludovic35 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ludovic35 ludovic35

Labels
⌛ waiting for validations The issue associated to this pull request is being reviewed by PO / a11y tea design team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Create component - Checkbox
2 participants
@pylapp @ludovic35