-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed limitation for --cookie-jar to use only one hurl file #3714
base: master
Are you sure you want to change the base?
Removed limitation for --cookie-jar to use only one hurl file #3714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lilyhuang-github some changes to be address; also could you please squash you commits to a single one and you have your commits to be signed (there is so information on it in the CONTRIBUTING guide).

1c9d7c4
to
4697360
Compare
Hi, I've implemented the changes, squashed into one commit and it should be verified/signed now. Sorry about accidentally changing the old documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lilyhuang-github there are still modifications on files that musn't be changed
4697360
to
6cab10c
Compare
Sorry, I thought I changed it back. It should be correct now. |
6cab10c
to
a7c032a
Compare
I accidentally added the (only for one session) twice but it should be correct now. |
I changed the integration test output for the cookie-jar since it changed. If it's ok I can rebase it. If it's not I can undo the commit. |
Hi @lilyhuang-github it's perfect! |
Hi @lilyhuang-github you have to change also
to
|
9f4a197
to
dacd2fc
Compare
I've added this change and also changed the README.md's cookie-jar explaination and rebased. |
@lilyhuang-github just a small fix:
|
dacd2fc
to
da1ff9e
Compare
I've added that fix and rebased now. |
Hi, |
Fix formatting Changed documentation back and add comments to indicate file Revert doc Update unit test
da1ff9e
to
f11943b
Compare
Sorry, I've ran the formatting with it now. |
@lilyhuang-github you've to run |
This removes the limitation of only allowing for one hurl file with the --cookie-jar argument and updates the documentation as such.
Should Closes #2537