Skip to content

Rename from "Mach" to "MISO" #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

Rename from "Mach" to "MISO" #64

merged 1 commit into from
Aug 1, 2023

Conversation

tuckerbabcock
Copy link
Member

@tuckerbabcock tuckerbabcock commented Jul 31, 2023 •
edited
Loading

This PR renames all types, files, etc. from "mach" to the new name, "MISO".

@tuckerbabcock tuckerbabcock changed the title Rename everything from "Mach" to "MISO Rename from "Mach" to "MISO" Jul 31, 2023
@tuckerbabcock tuckerbabcock changed the base branch from master to dev July 31, 2023 18:59
@Aerokaur
Copy link
Member

What is MISO ?

@tuckerbabcock
Copy link
Member Author

tuckerbabcock commented Jul 31, 2023 •
edited
Loading

It's our Multi-physics Integrated Simulations and Optimization (MISO) library 🙂. Renamed in part to avoid confusion with https://github.com/mdolab/MACH-Aero when we release this open-source.

@jehicken
Copy link
Contributor

jehicken commented Aug 1, 2023

Thanks @tuckerbabcock. Does this include the flow residual code (the stuff we used for Luiz's work)? I am having trouble finding it. (Was I supposed to merge that?)

@jehicken
Copy link
Contributor

jehicken commented Aug 1, 2023

I just saw #63. This might demand a meeting to understand where things stand.

@tuckerbabcock
Copy link
Member Author

I don't think this explicitly included the solver we used for Luiz's work. My intention was to change the dev branch, and then before any other branches are merged into dev, we would merge dev into them and the renamed would propagate through. #63 is somewhat of a work in progress PR to remind me to eventually merge it. I think too much has changed since I opened it to merge it right away. Happy to meet to further discuss this though.

@jehicken
Copy link
Contributor

jehicken commented Aug 1, 2023

Ok, if you think merging the flow-residual branch(es) will be relatively straightforward, then let's proceed.

@jehicken jehicken closed this Aug 1, 2023
@jehicken jehicken reopened this Aug 1, 2023
jehicken
jehicken approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jehicken jehicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much to review thoroughly, I am just going to assume our tests will catch any issues.

@jehicken jehicken merged commit d42dcf1 into dev Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehicken jehicken jehicken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuckerbabcock @Aerokaur @jehicken