Skip to content

Optable rtd provider update #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Optable rtd provider update #4

wants to merge 3 commits into from

Conversation

@justadreamer
Copy link
Collaborator

(this PR is for internal review, the description needs to be updated before publishing)

Type of change

  • Module updated

Description of change

Simplified the integration, removed unneeded bundleUrl parameter, updated the custom handler fallback logic and example.

@justadreamer
Copy link
Collaborator Author

TODOs:

  1. Resolve the conflicts with the main branch -> port to .ts
  2. Evaluate the balance of logic between the custom handleRtd and the default one

cc: @shaitanoleksandr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@justadreamer @BohdanVV