-
Notifications
You must be signed in to change notification settings - Fork 3
Import a csv file to delete users + count flag for services #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tozach
wants to merge
5
commits into
main
Choose a base branch
from
tozach
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e6e5ad9
Added new flag to get count of services
1021507
Added support to delete users via import csv
18cea96
Removed unecessary comments
5d234a2
Removed unecessary comments. The change includes an update to get ser…
2b2392b
Added changie
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
kind: Feature | ||
body: Added count flag for services list. Added user delete on import csv | ||
time: 2024-11-12T10:25:08.084783-05:00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -215,6 +215,41 @@ EOF | |
}, | ||
} | ||
|
||
var bulkDeleteUsersCmd = &cobra.Command{ | ||
Use: "delete users", | ||
Aliases: []string{"bulk delete users"}, | ||
Short: "Deletes users from a CSV", | ||
Long: `Deletes a list of users from a CSV file with the column headers: | ||
Email`, | ||
Example: ` | ||
cat << EOF | opslevel import delete users -f - | ||
[email protected] | ||
[email protected] | ||
[email protected] | ||
EOF | ||
`, | ||
Run: func(cmd *cobra.Command, args []string) { | ||
reader, err := readImportFilepathAsCSV() | ||
cobra.CheckErr(err) | ||
for reader.Rows() { | ||
email := reader.Text("Email") | ||
if email == "" { | ||
log.Error().Msgf("user has invalid email '%s'", email) | ||
continue | ||
} else { | ||
err := getClientGQL().DeleteUser(email) | ||
if err != nil { | ||
log.Error().Err(err).Msgf("error deleting user '%s'", email) | ||
continue | ||
} else { | ||
log.Info().Msgf("deleted user '%s'", email) | ||
} | ||
} | ||
} | ||
}, | ||
} | ||
|
||
func init() { | ||
createUserCmd.Flags().Bool("skip-welcome-email", false, "If this flag is set the welcome e-mail will be skipped from being sent") | ||
listUserCmd.Flags().Bool("ignore-deactivated", false, "If this flag is set only return active users") | ||
|
@@ -226,4 +261,5 @@ func init() { | |
listCmd.AddCommand(listUserCmd) | ||
deleteCmd.AddCommand(deleteUserCmd) | ||
importCmd.AddCommand(importUsersCmd) | ||
importCmd.AddCommand(bulkDeleteUsersCmd) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tozach - so I think the where we want to put this is in the normal
delete users
command but add a--bulk
or--csv
. Thats a bit more of a surgery so do you mind if I checkout this branch and muck with the code to get that to work?I definitely don't want it under the
import
command