added flask admin #331
Closed
added flask admin #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
localhost:5000/admin |
aaron-junot
requested changes
Jun 24, 2020
There was a problem hiding this comment.
This is looking good so far, but it needs to be behind authentication. Feel free to pull in Flask Security and add users and all that, or else we need to make it an authenticated route and introduce the idea of "admin" API users. I don't want just anyone to get access to flask admin, I want it to be a select set of users that are assigned through a people process.
If you go the flask security route, you can take some inspiration from this example https://github.com/sasaporta/flask-security-admin-example
|
Closing in favor of #403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flask admin for Resource, Category and Language models.