Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Member
Author
|
@claude review |
There was a problem hiding this comment.
Pull request overview
This PR primarily standardizes imports and formatting across the codebase (notably moving to the @/ path alias) and updates related tests/snapshots/config to match.
Changes:
- Migrated many imports from relative/alias paths (e.g.,
components/*,common/*) to the@/*alias. - Applied automated formatting updates (arrow parens, Tailwind class ordering) and regenerated snapshots.
- Updated tooling/configuration (Playwright
testDir, Storybook static dirs, Prettier Tailwind plugin) and moved/added a few modules (e.g.,src/common/constants/api.ts,FontSection).
Reviewed changes
Copilot reviewed 252 out of 429 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/e2e/join.spec.ts | Formatting/arrow-parens consistency in Playwright test |
| src/e2e/hashlink.spec.ts | Minor lint/format updates in e2e tests |
| src/components/Timeline/historyData.tsx | Switch import to @/ alias |
| src/components/Timeline/tests/Timeline.test.tsx | Switch test utils import to @/ |
| src/components/Timeline/TimelineNav/tests/snapshots/TimelineNav.test.tsx.snap | Added regenerated snapshot |
| src/components/Timeline/TimelineNav/tests/TimelineNav.test.tsx | Switch test utils import to @/ |
| src/components/Timeline/TimelineNav/TimelineNav.tsx | Formatting + class order changes |
| src/components/Timeline/TimelineEvent/tests/snapshots/TimelineEvent.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Timeline/TimelineEvent/tests/TimelineEvent.test.tsx | Switch test utils import to @/ |
| src/components/Timeline/TimelineEvent/TimelineEvent.tsx | Class order changes |
| src/components/Timeline/Timeline.tsx | Formatting + class order changes |
| src/components/SuccessStory/tests/snapshots/SuccessStory.test.tsx.snap | Snapshot updated for class ordering |
| src/components/SuccessStory/tests/SuccessStory.test.tsx | Switch test utils import to @/ |
| src/components/SuccessStory/stories/SuccessStory.stories.tsx | Switch imports to @/ + formatting |
| src/components/SuccessStory/SuccessStory.tsx | Switch import to @/ |
| src/components/SocialMedia/tests/snapshots/SocialMedia.test.tsx.snap | Snapshot updated for class ordering |
| src/components/SocialMedia/tests/SocialMedia.test.tsx | Switch test utils import to @/ |
| src/components/SocialMedia/SocialMediaItem/tests/SocialMediaItem.test.tsx | Switch imports to @/ |
| src/components/SocialMedia/SocialMediaItem/SocialMediaItem.tsx | Switch imports to @/ |
| src/components/SocialMedia/SocialMedia.tsx | Switch icon imports to @/ + class order |
| src/components/ScrollToTopButton/tests/snapshots/ScrollToTopButton.test.tsx.snap | Snapshot updated for class ordering |
| src/components/ScrollToTopButton/tests/ScrollToTopButton.test.tsx | Switch test utils import to @/ |
| src/components/ScrollToTopButton/ScrollToTopButton.tsx | Switch import to @/ + class refactor |
| src/components/ScreenReaderOnly/tests/ScreenReaderOnly.test.tsx | Switch test utils import to @/ |
| src/components/ScreenReaderOnly/stories/ScreenReaderOnly.stories.tsx | Formatting updates |
| src/components/ScreenReaderOnly/ScreenReaderOnly.tsx | Switch constants import to @/ |
| src/components/ReusableSections/SponsorsSection/tests/snapshots/SponsorsSection.test.tsx.snap | Snapshot updated for class ordering |
| src/components/ReusableSections/SponsorsSection/tests/SponsorsSection.test.tsx | Switch imports to @/ + formatting |
| src/components/ReusableSections/SponsorsSection/SponsorsSection.tsx | Switch imports to @/ + class order |
| src/components/ReusableSections/JoinSection/tests/snapshots/JoinSection.test.tsx.snap | Snapshot updated for class ordering |
| src/components/ReusableSections/JoinSection/tests/JoinSection.test.tsx | Switch test utils import to @/ |
| src/components/ReusableSections/JoinSection/JoinSection.tsx | Switch imports to @/ |
| src/components/ReusableSections/DonateSection/tests/snapshots/DonateSection.test.tsx.snap | Snapshot updated for class ordering |
| src/components/ReusableSections/DonateSection/tests/DonateSection.test.tsx | Switch test utils import to @/ |
| src/components/ReusableSections/DonateSection/stories/DonateSection.stories.tsx | Formatting updates |
| src/components/ReusableSections/DonateSection/DonateSection.tsx | Switch imports to @/ |
| src/components/ProgressIndicator/tests/ProgressIndicator.test.tsx | Switch test utils import to @/ |
| src/components/ProgressIndicator/stories/ProgressIndicator.stories.tsx | Story doc import path updated to @/ |
| src/components/Press/PressVideos/tests/snapshots/PressVideos.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Press/PressVideos/tests/PressVideos.test.tsx | Switch test utils import to @/ |
| src/components/Press/PressVideos/PressVideos.tsx | Formatting + class order changes |
| src/components/Press/PressPhotos/tests/snapshots/PressPhotos.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Press/PressPhotos/tests/PressPhotos.test.tsx | Switch test utils import to @/ |
| src/components/Press/PressPhotos/PressPhotos.tsx | Switch imports to @/ + formatting |
| src/components/Press/PressLinks/tests/snapshots/PressLinks.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Press/PressLinks/tests/PressLinks.test.tsx | Switch test utils import to @/ |
| src/components/Press/PressLinks/PressLinks.tsx | Switch imports to @/ + formatting |
| src/components/PartnerLogoLink/tests/PartnerLogoLink.test.tsx | Switch test utils import to @/ |
| src/components/PartnerLogoLink/stories/PartnerLogoLink.stories.tsx | Switch s3 import to @/ + formatting |
| src/components/PartnerLogoLink/PartnerLogoLink.tsx | Switch OutboundLink import to @/ + class order |
| src/components/OutboundLink/tests/snapshots/OutboundLink.test.tsx.snap | Snapshot updated for class ordering |
| src/components/OutboundLink/tests/OutboundLink.test.tsx | Switch test utils import to @/ |
| src/components/OutboundLink/stories/OutboundLink.stories.tsx | Switch descriptions import to @/ + formatting |
| src/components/OutboundLink/OutboundLink.tsx | Switch imports to @/ + class order |
| src/components/Nav/tests/snapshots/Nav.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Nav/tests/Nav.test.tsx | Switch imports to @/ |
| src/components/Nav/NavMobile/tests/snapshots/NavMobile.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Nav/NavMobile/tests/NavMobile.test.tsx | Switch imports to @/ |
| src/components/Nav/NavMobile/NavMobile.tsx | Switch imports to @/ + class order |
| src/components/Nav/NavListItem/tests/snapshots/NavListItem.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Nav/NavListItem/tests/NavListItem.test.tsx | Switch imports to @/ |
| src/components/Nav/NavListItem/NavListItem.tsx | Switch imports to @/ + formatting |
| src/components/Nav/Nav.tsx | Switch imports to @/ + dynamic import path update |
| src/components/Modal/tests/snapshots/Modal.test.tsx.snap | Snapshot updated for class ordering/z-index |
| src/components/Modal/tests/Modal.test.tsx | Switch gtag import to @/ |
| src/components/Modal/stories/Modal.stories.tsx | Switch imports to @/ + formatting |
| src/components/Modal/Modal.tsx | Switch imports to @/ + class refactor |
| src/components/InlineLoadingSpinner.tsx | Switch cx import to @/ + class refactor |
| src/components/HeroBanner/tests/snapshots/HeroBanner.test.tsx.snap | Snapshot updated for class ordering |
| src/components/HeroBanner/tests/HeroBanner.test.tsx | Switch imports to @/ |
| src/components/HeroBanner/stories/HeroBanner.stories.tsx | Formatting updates |
| src/components/HeroBanner/HeroBanner.tsx | Switch imports to @/ + class order |
| src/components/Heading/tests/snapshots/Heading.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Heading/tests/Heading.test.tsx | Switch test utils import to @/ |
| src/components/Heading/stories/Heading.stories.tsx | Formatting updates |
| src/components/Heading/Heading.tsx | Switch imports to @/ + class refactor |
| src/components/Forms/UpdateProfileForm/steps/tests/snapshots/ProfessionalDetails.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Forms/UpdateProfileForm/steps/tests/snapshots/MilitaryStatus.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Forms/UpdateProfileForm/steps/tests/ProfessionalDetails.test.tsx | Switch imports to @/ |
| src/components/Forms/UpdateProfileForm/steps/tests/PersonalDetails.test.tsx | Switch imports to @/ |
| src/components/Forms/UpdateProfileForm/steps/tests/MilitaryStatus.test.tsx | Switch imports to @/ |
| src/components/Forms/UpdateProfileForm/steps/tests/MilitaryDetails.test.tsx | Switch imports to @/ |
| src/components/Forms/UpdateProfileForm/steps/ProfessionalDetails.tsx | Switch imports to @/ |
| src/components/Forms/UpdateProfileForm/steps/PersonalDetails.tsx | Switch imports to @/ |
| src/components/Forms/UpdateProfileForm/steps/MilitaryStatus.tsx | Switch imports to @/ + formatting |
| src/components/Forms/UpdateProfileForm/steps/MilitaryDetails.tsx | Switch imports to @/ + formatting |
| src/components/Forms/UpdateProfileForm/tests/snapshots/UpdateProfileForm.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Forms/UpdateProfileForm/tests/UpdateProfileForm.test.tsx | Switch test utils import to @/ |
| src/components/Forms/UpdateProfileForm/stories/UpdateProfileForm.stories.tsx | Switch imports to @/ |
| src/components/Forms/UpdateProfileForm/UpdateProfileForm.tsx | Switch imports to @/ + formatting |
| src/components/Forms/RegistrationForm/tests/RegistrationForm.test.tsx | Switch imports to @/ + formatting |
| src/components/Forms/RegistrationForm/stories/RegistrationForm.stories.tsx | Formatting updates |
| src/components/Forms/RegistrationForm/RegistrationForm.tsx | Switch imports to @/ + minor typing simplification |
| src/components/Form/tests/Form.test.tsx | Switch test utils import to @/ |
| src/components/Form/Select/tests/ThemedReactSelect.test.tsx | Switch test utils import to @/ |
| src/components/Form/Select/tests/SelectSingle.test.tsx | Switch imports to @/ |
| src/components/Form/Select/tests/SelectMulti.test.tsx | Switch imports to @/ |
| src/components/Form/Select/stories/SelectSingle.stories.tsx | Add safe console lint disable + formatting |
| src/components/Form/Select/stories/SelectMulti.stories.tsx | Add safe console lint disable + formatting |
| src/components/Form/Select/ThemedReactSelect.tsx | Type formatting + arrow parens |
| src/components/Form/Select/SelectSingle.tsx | Switch imports to @/ + formatting |
| src/components/Form/Select/SelectMulti.tsx | Switch imports to @/ + formatting |
| src/components/Form/MultiStepForm.tsx | Switch imports to @/ + formatting |
| src/components/Form/Label/tests/Label.test.tsx | Switch imports to @/ |
| src/components/Form/Label/stories/Label.stories.tsx | Formatting updates |
| src/components/Form/Label/Label.tsx | Switch imports to @/ |
| src/components/Form/Input/tests/snapshots/Input.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Form/Input/tests/Input.test.tsx | Switch imports to @/ + formatting |
| src/components/Form/Input/stories/Input.stories.tsx | Formatting updates |
| src/components/Form/Input/Input.tsx | Switch imports to @/ + class order |
| src/components/Form/Checkbox/Checkbox.tsx | Switch imports to @/ + class order |
| src/components/Footer/tests/snapshots/Footer.test.tsx.snap | Snapshot updated for class ordering/assets |
| src/components/Footer/tests/Footer.test.tsx | Switch test utils import to @/ |
| src/components/Footer/Footer.tsx | Switch imports/assets to @/ + formatting |
| src/components/FeaturedJobItem/tests/snapshots/FeaturedJobItem.test.tsx.snap | Snapshot updated for class ordering |
| src/components/FeaturedJobItem/tests/FeaturedJobItem.test.tsx | Switch test utils import to @/ |
| src/components/FeaturedJobItem/stories/FeaturedJobItem.stories.tsx | Switch descriptions import to @/ |
| src/components/FeaturedJobItem/FeaturedJobItem.tsx | Switch imports to @/ + class order |
| src/components/ErrorDisplay/tests/snapshots/ErrorDisplay.test.tsx.snap | Snapshot updated for class ordering |
| src/components/ErrorDisplay/tests/ErrorDisplay.test.tsx | Switch test utils import to @/ |
| src/components/ErrorDisplay/ErrorDisplay.tsx | Class order changes |
| src/components/Drawer/tests/snapshots/Drawer.test.tsx.snap | Snapshot updated for class ordering/z-index |
| src/components/Drawer/tests/Drawer.test.tsx | Switch test utils import to @/ |
| src/components/Drawer/stories/Drawer.stories.tsx | Formatting updates |
| src/components/Drawer/Drawer.tsx | Switch cx import to @/ + class refactor |
| src/components/Content/tests/snapshots/Content.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Content/tests/Content.test.tsx | Switch test utils import to @/ |
| src/components/Content/stories/Content.stories.tsx | Formatting updates |
| src/components/Content/Content.tsx | Switch imports to @/ + JSX changes |
| src/components/Container/tests/snapshots/Container.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Container/tests/Container.test.tsx | Switch imports to @/ |
| src/components/Container/stories/Container.stories.tsx | Switch descriptions import to @/ |
| src/components/Container/Container.tsx | Switch imports to @/ + class order |
| src/components/Cards/ValueCard/tests/snapshots/ValueCard.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Cards/ValueCard/tests/ValueCard.test.tsx | Switch test utils import to @/ |
| src/components/Cards/ValueCard/stories/ValueCard.stories.tsx | Switch descriptions import to @/ |
| src/components/Cards/ValueCard/ValueCard.tsx | Switch Card import to @/ + class order |
| src/components/Cards/ImageCard/tests/snapshots/ImageCard.test.tsx.snap | Added regenerated snapshot |
| src/components/Cards/ImageCard/tests/ImageCard.test.tsx | Switch test utils import to @/ |
| src/components/Cards/ImageCard/stories/ImageCard.stories.tsx | Switch imports to @/ |
| src/components/Cards/ImageCard/ImageCard.tsx | Switch imports to @/ + class refactor |
| src/components/Cards/FlatCard/tests/snapshots/FlatCard.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Cards/FlatCard/tests/FlatCard.test.tsx | Switch imports to @/ |
| src/components/Cards/FlatCard/stories/FlatCard.stories.tsx | Switch descriptions import to @/ + formatting |
| src/components/Cards/FlatCard/FlatCard.tsx | Switch imports to @/ + class refactor |
| src/components/Cards/Card/tests/snapshots/Card.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Cards/Card/tests/Card.test.tsx | Switch test utils import to @/ |
| src/components/Cards/Card/stories/Card.stories.tsx | Switch descriptions import to @/ |
| src/components/Cards/Card/Card.tsx | Switch imports to @/ + class refactor |
| src/components/Buttons/LinkButton/tests/snapshots/LinkButton.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Buttons/LinkButton/tests/LinkButton.test.tsx | Switch imports to @/ |
| src/components/Buttons/LinkButton/stories/LinkButton.stories.tsx | Formatting updates |
| src/components/Buttons/LinkButton/LinkButton.tsx | Switch imports to @/ |
| src/components/Buttons/CloseButton/tests/snapshots/CloseButton.test.tsx.snap | Snapshot updated for rotate class |
| src/components/Buttons/CloseButton/tests/CloseButton.test.tsx | Switch imports to @/ |
| src/components/Buttons/CloseButton/stories/CloseButton.stories.tsx | Formatting updates |
| src/components/Buttons/CloseButton/CloseButton.tsx | Switch imports to @/ + rotate class change |
| src/components/Buttons/Button/tests/snapshots/Button.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Buttons/Button/tests/Button.test.tsx | Switch imports to @/ |
| src/components/Buttons/Button/stories/Button.stories.tsx | Formatting updates |
| src/components/Buttons/Button/Button.tsx | Switch imports to @/ + cva refactor |
| src/components/Branding/Swatch/tests/snapshots/Swatch.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Branding/Swatch/tests/Swatch.test.tsx | Switch test utils import to @/ |
| src/components/Branding/Swatch/Swatch.tsx | Switch ScreenReaderOnly import to @/ |
| src/components/Branding/LogoSection/tests/snapshots/LogoSection.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Branding/LogoSection/tests/LogoSection.test.tsx | Switch test utils import to @/ |
| src/components/Branding/LogoSection/LogoSection.tsx | Switch imports to @/ + formatting |
| src/components/Branding/FontSection/tests/snapshots/FontSection.test.tsx.snap | Snapshot updated for new typography rendering |
| src/components/Branding/FontSection/tests/FontSection.test.tsx | Switch test utils import to @/ |
| src/components/Branding/FontSection/FontSection.tsx | New FontSection implementation under src/ |
| src/components/Branding/ColorSection/tests/ColorSection.test.tsx | Switch test utils import to @/ |
| src/components/Branding/ColorSection/ColorSection.tsx | Switch imports to @/ |
| src/components/Badge/tests/Badge.test.tsx | Switch imports to @/ |
| src/components/Badge/stories/Badge.stories.tsx | Switch icon imports to @/ + formatting |
| src/components/Badge/Badge.tsx | Switch cx import to @/ |
| src/components/Analytics/AnalyticsProvider.tsx | Switch gtag import to @/ + formatting |
| src/components/Alert/tests/snapshots/Alert.test.tsx.snap | Snapshot updated for class ordering |
| src/components/Alert/tests/Alert.test.tsx | Switch imports to @/ |
| src/components/Alert/stories/Alert.stories.tsx | Formatting updates |
| src/components/Alert/Alert.tsx | Switch imports to @/ + class refactor |
| src/components/Accordion/tests/Accordion.test.tsx | Switch constants import to @/ |
| src/components/Accordion/stories/Accordion.stories.tsx | Formatting updates |
| src/components/Accordion/Accordion.tsx | Switch imports to @/ + formatting |
| src/common/utils/thirdParty/gtag.ts | Switch environment import to @/ |
| src/common/utils/next-utils.js | Formatting (arrow parens) |
| src/common/utils/cva.ts | Formatting + export comment |
| src/common/utils/array-utils.ts | Formatting (arrow parens) |
| src/common/utils/api-utils.ts | Switch imports to @/ + lint suppression |
| src/common/utils/tests/array-utils.test.ts | Switch imports to @/ |
| src/common/utils/tests/api-utils.test.js | Switch imports to @/ |
| src/common/styles/globals.css | Tailwind import update + @apply ordering |
| src/common/constants/partners.ts | Switch imports/assets to @/ |
| src/common/constants/api.ts | Added new src/ location for API wrappers |
| src/common/config/svgo.js | Remove eslint disable comment |
| src/app/thank_you/ThankYouContent.tsx | Switch imports to @/ + class order |
| src/app/terms/page.tsx | Switch imports to @/ |
| src/app/team/page.tsx | Switch imports/assets to @/ + class changes |
| src/app/sponsorship/page.tsx | Switch imports to @/ + class changes |
| src/app/slack_guide/page.tsx | Switch imports to @/ + class changes |
| src/app/services/page.tsx | Switch imports to @/ + formatting |
| src/app/scholarship/page.tsx | Switch imports to @/ + class changes |
| src/app/scholarship/code_platoon/CodePlatoonContent.tsx | Switch imports to @/ + DOM append usage |
| src/app/project_rebuild/page.tsx | Switch imports to @/ + class changes |
| src/app/press/page.tsx | Replace barrel import with direct imports |
| src/app/policy/page.tsx | Switch imports to @/ + class refactor |
| src/app/podcast/page.tsx | Switch imports to @/ + class order |
| src/app/page.tsx | Switch imports to @/ + formatting |
| src/app/not-found.tsx | Switch import to @/ |
| src/app/layout.tsx | Switch imports to @/ including global CSS |
| src/app/join/success/page.tsx | Switch imports to @/ |
| src/app/join/form/page.tsx | Switch imports to @/ |
| src/app/join/JoinContent.tsx | Switch imports to @/ + class order |
| src/app/jobs/page.tsx | Switch imports to @/ + formatting |
| src/app/history/page.tsx | Switch imports to @/ + class changes |
| src/app/global-error.tsx | Switch import to @/ |
| src/app/faq/page.tsx | Switch imports to @/ |
| src/app/error.tsx | Switch import to @/ |
| src/app/donate/page.tsx | Switch imports to @/ + class changes |
| src/app/corporate-training/page.tsx | Switch imports to @/ + class refactor |
| src/app/contact/page.tsx | Switch imports to @/ + class order |
| src/app/chapters/page.tsx | Switch imports to @/ + class changes |
| src/app/chapter_leader/page.tsx | Switch imports to @/ |
| src/app/challenge/page.tsx | Switch imports to @/ + class changes |
| src/app/branding/page.tsx | Switch imports to @/ + class order |
| src/app/blog/page.tsx | Switch import to @/ |
| src/app/api/registration/update/route.ts | Switch imports to @/ + formatting |
| src/app/api/registration/new/route.ts | Switch imports to @/ |
| src/app/about/page.tsx | Switch imports to @/ + class changes |
| src/.storybook/preview.js | Switch global CSS import to @/ + decorator formatting |
| src/.storybook/main.ts | Adjust staticDirs path + formatting |
| prettier.config.js | Add Tailwind Prettier plugin + arrowParens change |
| playwright.config.ts | Update Playwright testDir to src/e2e |
| pathAliases.js | Removed legacy alias config |
| jsconfig.json | Removed legacy JS path config |
| components/Timeline/TimelineNav/tests/snapshots/TimelineNav.test.tsx.snap | Removed old snapshot path |
| components/Press/index.ts | Removed Press barrel export |
| components/Cards/ImageCard/tests/snapshots/ImageCard.test.tsx.snap | Removed old snapshot path |
| components/Branding/FontSection/FontSection.tsx | Removed old FontSection path |
| common/constants/api.ts | Removed old API constants path |
| README.md | Update e2e command wording + image URLs |
| CONTRIBUTING.md | Update file structure/docs for src/ + Playwright |
| .vscode/settings.json | VS Code settings updated |
| .lintstagedrc | Add eslint --no-warn-ignored |
| .eslintignore | Removed eslint ignore file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| aria-hidden | ||
| className={cx( | ||
| 'border-solid border-white border-4 !border-b-primary rounded-[50%] h-5 w-5 box-border animate-spin group-hover:border-secondary transition-colors', | ||
| `box-border size-5 animate-spin rounded-[50%] border-4 border-solid border-white border-b-primary! transition-colors group-hover:border-secondary`, |
There was a problem hiding this comment.
Tailwind's important modifier syntax is incorrect here. border-b-primary! is not a valid Tailwind class, so the spinner's bottom border color will likely not apply. Use the prefix form (!border-b-primary) or an equivalent styling approach.
Suggested change
| `box-border size-5 animate-spin rounded-[50%] border-4 border-solid border-white border-b-primary! transition-colors group-hover:border-secondary`, | |
| `box-border size-5 animate-spin rounded-[50%] border-4 border-solid border-white !border-b-primary transition-colors group-hover:border-secondary`, |
| {(formikBag) => ( | ||
| <Form | ||
| className="flex flex-col gap-4 w-full max-w-prose px-4 !m-0" | ||
| className="m-0! flex w-full max-w-prose flex-col gap-4 px-4" |
There was a problem hiding this comment.
Tailwind important modifier syntax is reversed. m-0! is not a valid Tailwind class (important uses a leading !, e.g. !m-0). This likely breaks the intended margin override in the form layout.
Suggested change
| className="m-0! flex w-full max-w-prose flex-col gap-4 px-4" | |
| className="!m-0 flex w-full max-w-prose flex-col gap-4 px-4" |
| > | ||
| {({ isSubmitting }) => ( | ||
| <Form className="flex flex-col gap-4 max-w-prose w-full px-4 !m-0"> | ||
| <Form className="m-0! flex w-full max-w-prose flex-col gap-4 px-4"> |
There was a problem hiding this comment.
Same Tailwind important modifier issue as elsewhere: m-0! is not a valid utility. If the goal is to force margin: 0, this should be !m-0 (or remove the need for an important override).
Suggested change
| <Form className="m-0! flex w-full max-w-prose flex-col gap-4 px-4"> | |
| <Form className="!m-0 flex w-full max-w-prose flex-col gap-4 px-4"> |
| return ( | ||
| <Card | ||
| className="!justify-start max-w-[400px] h-[400px] p-8 overflow-y-auto" | ||
| className="h-[400px] max-w-[400px] justify-start! overflow-y-auto p-8" |
There was a problem hiding this comment.
Tailwind important modifier is reversed again. justify-start! is not valid Tailwind syntax, so the override won't apply. Use !justify-start (or adjust the base Card styles so an important override isn't needed).
Suggested change
| className="h-[400px] max-w-[400px] justify-start! overflow-y-auto p-8" | |
| className="h-[400px] max-w-[400px] !justify-start overflow-y-auto p-8" |
| src={`${s3}github_demo/example.png`} | ||
| alt="screenshot of what the screen should look like on GitHub thus far" | ||
| className="!p-0" | ||
| className="p-0!" |
There was a problem hiding this comment.
p-0! is not valid Tailwind important syntax, so the padding override likely won't apply. Use !p-0 instead.
Suggested change
| className="p-0!" | |
| className="!p-0" |
| variants: { | ||
| disabled: { | ||
| false: 'group-hover:rotate-[135deg]', | ||
| false: 'group-hover:rotate-135', |
There was a problem hiding this comment.
rotate-135 is not a standard Tailwind rotate utility by default. Previously this used an arbitrary value (rotate-[135deg]), which is always safe. Unless Tailwind has been extended to include 135, the hover animation will stop working; consider reverting to group-hover:rotate-[135deg] or adding 135 to the Tailwind theme.rotate scale.
Suggested change
| false: 'group-hover:rotate-135', | |
| false: 'group-hover:rotate-[135deg]', |
| title="The Team" | ||
| backgroundImageSource={`${s3}oc_crew_nyc_2021.jpg`} | ||
| className="bg-[center_30%] min-h-[60dvh]" | ||
| className="min-h-[60dvh] bg-position-[center_30%]" |
There was a problem hiding this comment.
bg-position-[...] is not a standard Tailwind utility form (Tailwind background-position utilities use the bg-* prefix, and arbitrary values are typically expressed as bg-[...]). If this isn't backed by a custom plugin, the background positioning will be ignored. Consider reverting to the previous arbitrary utility (bg-[center_30%]) or another Tailwind-supported background-position utility.
Suggested change
| className="min-h-[60dvh] bg-position-[center_30%]" | |
| className="min-h-[60dvh] bg-[center_30%]" |
Comment on lines
+57
to
60
| {} | ||
| {columns.map((column, index) => | ||
| cloneElement(column as ReactElement<unknown>, { key: index }), | ||
| )} |
There was a problem hiding this comment.
The standalone {} is a no-op JSX expression and should be removed. Also, using the array index as a key can cause unnecessary remounts if columns order changes; since columns are React elements, prefer requiring a stable key on each element and reusing it (e.g., column.key) rather than overriding with index.
Suggested change
| {} | |
| {columns.map((column, index) => | |
| cloneElement(column as ReactElement<unknown>, { key: index }), | |
| )} | |
| {columns.map((column, index) => { | |
| const columnElement = column as ReactElement<unknown>; | |
| const key = columnElement.key ?? index; | |
| return cloneElement(columnElement, { key }); | |
| })} |
| @@ -1,11 +1,6 @@ | |||
| { | |||
| "typescript.tsdk": "node_modules/typescript/lib", | |||
| "js/ts.tsdk.path": "node_modules/typescript/lib", | |||
There was a problem hiding this comment.
This setting key does not match VS Code's standard TypeScript SDK configuration keys. Typically you want \"typescript.tsdk\" (and optionally \"javascript.tsdk\") instead. As-is, VS Code may ignore this and fall back to its bundled TypeScript version.
Suggested change
| "js/ts.tsdk.path": "node_modules/typescript/lib", | |
| "typescript.tsdk": "node_modules/typescript/lib", |
Comment on lines
+2
to
+5
| plugins: ['prettier-plugin-tailwindcss'], | ||
| tailwindStylesheet: './src/common/styles/globals.css', | ||
| tailwindFunctions: ['cx'], | ||
| arrowParens: 'always', |
There was a problem hiding this comment.
The PR title/description indicate dependency upgrades, but the visible changes are mainly formatting (Prettier/Tailwind sorting, arrowParens) and path-alias refactors. Consider updating the PR title/description to reflect the actual scope (or splitting formatting/path-alias churn from actual dependency upgrades) to make review and rollback safer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue Resolved
Fixes #NA
Screenshots/GIFs