Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PaymasterNFT and PaymasterERC20 #75

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 1, 2025

Includes a slight refactor of the behavior tests

@Amxx Amxx requested a review from a team as a code owner February 1, 2025 20:04
@Amxx Amxx requested review from arr00 and ernestognw February 1, 2025 20:08
@Amxx Amxx marked this pull request as draft February 3, 2025 15:37
@Amxx Amxx changed the title Add PaymasterERC721 Add ERC721Paymaster Feb 3, 2025
@Amxx Amxx changed the title Add ERC721Paymaster Add PaymasterNFT Feb 5, 2025
@Amxx Amxx changed the title Add PaymasterNFT Add PaymasterNFT and PaymasterERC20 Feb 6, 2025
@Amxx Amxx marked this pull request as ready for review February 6, 2025 13:46
Comment on lines +34 to +35
* NOTE: The `context` returned is `bytes(0)`. Developers overriding this function MUST
* override {_postOp} to process the context passed along.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* NOTE: The `context` returned is `bytes(0)`. Developers overriding this function MUST
* override {_postOp} to process the context passed along.
* NOTE: The default `context` returned is `bytes(0)`. Developers overriding this function, such that context is not `bytes(0)`, MUST
* override {_postOp} to process the context passed along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants