Skip to content

fix(deployer): pin ledger-v8 to the version midnight-js requires - #171

Merged
0xisk merged 1 commit into
mainfrom
fix/deployer-single-ledger-copy
Sep 8, 2026
Merged

fix(deployer): pin ledger-v8 to the version midnight-js requires#171
0xisk merged 1 commit into
mainfrom
fix/deployer-single-ledger-copy

Conversation

@0xisk

@0xisk 0xisk commented Sep 8, 2026

Copy link
Copy Markdown
Member

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Pre-release check of @openzeppelin/compact-deployer: the packed tarball installed
into a fresh npm project loads, but every deploy fails with
expected instance of DustParameters. midnight-js-protocol 4.1.1 requires
ledger-v8 8.1.0 exactly while the deployer pinned 8.1.2, so npm nested a
second ledger WASM. The workspace never saw it because the root resolutions
force one copy, and those do not ship.

Not visible in the diff:

  • 8.1.0 was picked over documenting a consumer-side override because npm then
    dedupes to one copy with no action from the user. yarn and pnpm resolve each
    range to the newest version regardless, so the README now carries the
    resolutions block they need.
  • Verified against the local stack: deployer unit tests, the 31-test
    integration suite on 8.1.0, and a Counter deploy from a fresh npm install of
    the packed tarball with no override.

PR Checklist

  • I have read the Contributing Guide
  • I have added tests that prove my fix is effective or that my feature works
  • I have added documentation of new methods and any new behavior or changes to existing behavior
  • CI Workflows Are Passing

@0xisk
0xisk requested review from a team as code owners September 8, 2026 11:10
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 475ecddc-2fc3-499c-8cf3-94be5dc9c0c9


Comment @coderabbitai help to get the list of available commands.

midnight-js-protocol 4.1.1 depends on ledger-v8 8.1.0 exactly. With the
deployer on 8.1.2 an npm install of the published package nests a second
ledger WASM and every deploy fails with "expected instance of
DustParameters". The workspace never hit it because the root resolutions
force one copy, and those do not ship.
@0xisk
0xisk force-pushed the fix/deployer-single-ledger-copy branch from 024cf44 to b124bfe Compare September 8, 2026 11:10
@0xisk
0xisk merged commit 8358e9b into main Sep 8, 2026
10 checks passed
@0xisk
0xisk deleted the fix/deployer-single-ledger-copy branch September 8, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants