fix(deployer): pin ledger-v8 to the version midnight-js requires - #171
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Comment |
midnight-js-protocol 4.1.1 depends on ledger-v8 8.1.0 exactly. With the deployer on 8.1.2 an npm install of the published package nests a second ledger WASM and every deploy fails with "expected instance of DustParameters". The workspace never hit it because the root resolutions force one copy, and those do not ship.
0xisk
force-pushed
the
fix/deployer-single-ledger-copy
branch
from
September 8, 2026 11:10
024cf44 to
b124bfe
Compare
pepebndc
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Pre-release check of
@openzeppelin/compact-deployer: the packed tarball installedinto a fresh npm project loads, but every deploy fails with
expected instance of DustParameters.midnight-js-protocol4.1.1 requiresledger-v88.1.0 exactly while the deployer pinned 8.1.2, so npm nested asecond ledger WASM. The workspace never saw it because the root
resolutionsforce one copy, and those do not ship.
Not visible in the diff:
dedupes to one copy with no action from the user. yarn and pnpm resolve each
range to the newest version regardless, so the README now carries the
resolutions block they need.
integration suite on 8.1.0, and a Counter deploy from a fresh npm install of
the packed tarball with no override.
PR Checklist