Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Libcheckpoint repo #773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add Libcheckpoint repo #773

wants to merge 1 commit into from

Conversation

xyyy1420
Copy link
Contributor

@xyyy1420 xyyy1420 commented Jan 9, 2025

prepare replace LibcheckpointAlpha with LibCheckpoint

@xyyy1420 xyyy1420 requested a review from shinezyy January 9, 2025 06:46
@shinezyy
Copy link
Contributor

shinezyy commented Jan 9, 2025

Since libcheckpoint is not currently being used, how can we verify that this patch is correct?
Should we also include CI in thsi patch?

@xyyy1420
Copy link
Contributor Author

xyyy1420 commented Jan 9, 2025

Since libcheckpoint is not currently being used, how can we verify that this patch is correct? Should we also include CI in thsi patch?

Libcheckpoint is not currently being used, will not broken any NEMU function, just clone repo, i think we can add CI when we use Libcheckpoint?

shinezyy
shinezyy approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@shinezyy shinezyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinezyy shinezyy shinezyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xyyy1420 @shinezyy